Bug 154397 - Symlink an icon pack with _dark suffix doesn't work
Summary: Symlink an icon pack with _dark suffix doesn't work
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.4.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-25 20:51 UTC by Paul Kepinski
Modified: 2023-04-13 15:13 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Kepinski 2023-03-25 20:51:50 UTC
Description:
I maintain the Yaru icon pack, and it is already supporting very well the dark mode by design (even if I plan a real dark variant).
In order to avoid to take too much disk place (all variants in png and svg is already more than 100mo), I'd like to simply create a symlink between the default variant "images_yaru.zip" file to a "images_yaru_dark.zip" file. Awaiting LO supports icon pack inheritance.
Currently the automatic mode of LO doesn't pick the yaru icon pack in dark mode, but it does in light one.

Sadly this symlink trick doesn't work, because LO seems to read the symlink file like a simple duplication of the source file, without taking into account the name of the symlink file. It creates two same entries in the icon selector.
If I do a simple copy of "images_yaru.zip" to "images_yaru_dark.zip", it works as expected and I have two different entries: "Yaru" and "Yaru (dark)".

Steps to Reproduce:
1. symlink an icon pack zip with a _dark suffix
2. restart LO
3. Go to display settings and see the duplicated rows

Actual Results:
It shows two duplicated icon pack.

Expected Results:
It should display a normal and a dark variant.


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 Buovjaga 2023-04-13 12:14:00 UTC
What is this report about? Are you proposing that LibreOffice adopts some symlink trick?
Comment 2 Paul Kepinski 2023-04-13 12:44:36 UTC
I'm really sorry, I had forgotten that I opened this bug.

In fact, the automatic mode was selecting the wrong icon pack in dark mode.
But the ubuntu packaging team fixed the problem.
I just tested it in a fresh VM, and it works as expected.

So I think you can close this.
Comment 3 Buovjaga 2023-04-13 15:13:40 UTC
Thanks for following up