Bug 154446 - Redundant option for grid line color
Summary: Redundant option for grid line color
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Options-Dialog-Calc
  Show dependency treegraph
 
Reported: 2023-03-29 12:44 UTC by Heiko Tietze
Modified: 2023-12-06 19:43 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2023-03-29 12:44:29 UTC
Tools > Options > Calc > View (TOCV) > Visual Aids seems to be obsolete after bug 152184 / https://gerrit.libreoffice.org/c/core/+/149059 making (General) > Application Colors (AC) > (Spreadsheets) > Grid lines the primary color. Before this patch the grid color was set via Calc > View if AC was COL_AUTO; and TOCV being initialized to SC_STD_GRIDCOLOR = COL_LIGHTGRAY.

I suggest to remove the extra definition of grid colors from TOCV (sc/source/ui/optdlg/tpview.cxx), adjust the view options to follow svtools::CALC_GRID (sc/source/core/tool/viewopti.cxx), and use ColorConfig::GetDefaultColor() in sc/source/ui/view/viewdata.cxx.

See also bug 118295
Comment 1 Heiko Tietze 2023-03-29 13:14:59 UTC
Tentative patch at https://gerrit.libreoffice.org/c/core/+/149715
Comment 2 Commit Notification 2023-04-04 08:54:02 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2039fd382af9d110bd68be8629ab757b3617926a

Resolves tdf#154446 - Remove redundant option for grid line color

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.