Bug 154454 - Incorrect numbering in Show Changes mode
Summary: Incorrect numbering in Show Changes mode
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.3
Keywords:
Depends on:
Blocks: Track-Changes-Lists
  Show dependency treegraph
 
Reported: 2023-03-29 16:51 UTC by Matthew Kogan
Modified: 2024-09-17 08:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Document after step 5 (10.68 KB, application/vnd.oasis.opendocument.text)
2023-04-12 09:47 UTC, Dieter
Details
Document after step 7 (11.56 KB, application/vnd.oasis.opendocument.text)
2023-04-12 09:47 UTC, Dieter
Details
original (7.6) (11.12 KB, application/vnd.oasis.opendocument.text)
2023-04-12 12:47 UTC, Matthew Kogan
Details
changed (7.6) (11.29 KB, application/vnd.oasis.opendocument.text)
2023-04-12 12:48 UTC, Matthew Kogan
Details
comparison (7.6) (11.51 KB, application/vnd.oasis.opendocument.text)
2023-04-12 12:48 UTC, Matthew Kogan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Kogan 2023-03-29 16:51:22 UTC
Description:
Numbering is incorrect in Show Changes mode in some cases.

Steps to Reproduce:
1.In Writer, press F12 to enable numbering
2.Create nine numbered paragraphs
3.Demote the second, fifth, sixth, eighth, and ninth paragraphs one level
4.Click Format, Bullets and Numbering, Customise, increase Show sublevels to 2, click OK
5.Turn off numbering on the third paragraph
6.Save the document as "original"
7.Click at the end of the sixth paragraph, press Enter, and type some text
8.Save the document as "changed"
9.Click Edit, Track Changes, Compare Document, select "original"
10.Save the comparison as "comparison"
11.Close and re-open "comparison"

Actual Results:
The numbering on the last two paragraphs is reported to have changed from 2.4 to 3.1 and from 2.5 to 3.2.

Expected Results:
The numbering on the last two paragraphs should not be reported as having changed, because it hasn't.


Reproducible: Always


User Profile Reset: No

Additional Info:
If there is a way to just disable this new number comparison feature, that would be useful as a stopgap until it is fixed.
Comment 1 Dieter 2023-04-12 09:46:16 UTC
I can't confirm with

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1e9f4de320f67d1218c710bcee1969a2324c6888
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-GB
Calc: CL threaded

Manage changes dialog only shows the additional paragraph 2.3 (expected). Will attach the two documents.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1e9f4de320f67d1218c710bcee1969a2324c6888
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-GB
Calc: CL threaded
Comment 2 Dieter 2023-04-12 09:47:20 UTC
Created attachment 186602 [details]
Document after step 5
Comment 3 Dieter 2023-04-12 09:47:54 UTC
Created attachment 186603 [details]
Document after step 7
Comment 4 Matthew Kogan 2023-04-12 12:47:28 UTC
I can reproduce it in 7.6. I'll attach my files too.
Comment 5 Matthew Kogan 2023-04-12 12:47:59 UTC
Created attachment 186607 [details]
original (7.6)
Comment 6 Matthew Kogan 2023-04-12 12:48:14 UTC
Created attachment 186608 [details]
changed (7.6)
Comment 7 Matthew Kogan 2023-04-12 12:48:31 UTC
Created attachment 186609 [details]
comparison (7.6)
Comment 8 Dieter 2023-04-16 16:36:13 UTC
I've tried as follows:
1. Download attachment 186607 [details] and attachment 186608 [details]
2. Open attachment 186608 [details]
3. Edit -> Trach Changes -> Compare documents
4. Open downloaded attachement 186607

Actual and expected result
Only 2.3 is shown as change (different from attachment 186609 [details])

Matthew, could you please paste information from Help -> About LibreOffice? You can also try in SafeMode (Help -> Restart in SafeMode)

I hope somebody else can help.
Comment 9 Matthew Kogan 2023-04-16 20:33:48 UTC
Thank you Dieter but you seem to have skipped the last two of my steps, which are crucial:
10.Save the comparison as "comparison"
11.Close and re-open "comparison"
Comment 10 Buovjaga 2023-04-17 10:32:56 UTC
I repro and I bibisected with linux-64-7.5 at least two stages of this. The first one shows a change in paragraph "seven" already before saving and reloading:
 2413f213625253a9c2b1787b3b9fe859d724a9bd
tdf#115523 sw_redlinenum: show correct, also original numbering
 db1f4457543918b5e3cd8b4d3a70676855952314
tdf#149709 sw_redlinenum: fix list levels

Let's ask László what he thinks, not marking as regression for now.
Comment 11 Matthew Kogan 2023-06-23 16:02:08 UTC
I'm sorry to chase, but this is preventing me from upgrading to a current version of LibreOffice, which I really want to do. Would it be possible to add a config setting to just disable this new number comparison feature? No UI required, just a setting in the registry or a config file or something would be fine by me.
Comment 12 Commit Notification 2023-10-17 12:50:58 UTC
Matthew Kogan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d67d47bf0e9c9b24fb9aeed8807c31ed28d7fec2

tdf#154454 sw: make comparison of changed paragraph numbering optional

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Matthew Kogan 2023-10-18 09:52:49 UTC
It's probably best if someone else checks it too, given that I wrote the patch myself, but as the reporter of the bug I can say that I'm happy with the behaviour now (once the new preference has been set to false). Hopefully it can be back-ported to 7.6 in time for the code freeze.
Comment 14 Buovjaga 2023-10-18 10:51:07 UTC
Ok, you can close as resolved fixed
Comment 15 Matthew Kogan 2023-10-18 10:55:31 UTC
Technically I would say that the bug is not really fixed at this point - my patch just allows the user to work around it by hiding the faulty tracked numbering.
Comment 16 Commit Notification 2023-10-27 12:41:28 UTC
Matthew Kogan committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/fd0d7e7916efa0fcb4796b6a8fd7fccb586d56db

tdf#154454 sw: make comparison of changed paragraph numbering optional

It will be available in 7.6.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Dieter 2023-11-01 22:24:53 UTC
(In reply to Buovjaga from comment #10)
> I repro
=> NEW

Matthew, if you think it is fixed, please change status to RESOLVED FIXED.
Comment 18 Matthew Kogan 2023-11-01 22:29:00 UTC
As I said in comment 15, it's not fixed, I've just added a workaround. The incorrect numbering still needs fixing properly. If there is going to be a new bug report for that then fine, but until then this one should remain open in my opinion.
Comment 19 László Németh 2024-09-17 08:47:11 UTC
Note: I think, MSO's visualization is worse sometimes: it shows never existed numbering, as original [i.e. using standard visualization of track changes]. Also its typography/readability is very bad with the adjacent half-strikethrough digits. The ideal would be making that future visualization optional, or somehow better (adding narrow spaces between the adjacent digits?).