Bug 154549 - Hebrew Nikkud marks mis-positioned on Arabic letters
Summary: Hebrew Nikkud marks mis-positioned on Arabic letters
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: ⁨خالد حسني⁩
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords:
Depends on:
Blocks: Fonts RTL-Arabic-and-Farsi RTL-Hebrew
  Show dependency treegraph
 
Reported: 2023-04-01 21:30 UTC by ⁨خالد حسني⁩
Modified: 2023-05-28 11:53 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Test document (82.92 KB, application/vnd.oasis.opendocument.text)
2023-04-01 21:30 UTC, ⁨خالد حسني⁩
Details
Current rendering (65.48 KB, image/png)
2023-04-01 21:33 UTC, ⁨خالد حسني⁩
Details
Correct rendering in Firefox (23.65 KB, image/png)
2023-04-01 21:34 UTC, ⁨خالد حسني⁩
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ⁨خالد حسني⁩ 2023-04-01 21:30:37 UTC
Created attachment 186399 [details]
Test document

Some historical Arabic texts use Hebrew marks, but doing so in LibreOffice results in mispositioning of the marks.
Comment 1 ⁨خالد حسني⁩ 2023-04-01 21:33:34 UTC
Created attachment 186400 [details]
Current rendering
Comment 2 ⁨خالد حسني⁩ 2023-04-01 21:34:52 UTC
Created attachment 186401 [details]
Correct rendering in Firefox
Comment 3 ⁨خالد حسني⁩ 2023-04-01 21:39:13 UTC
Example of such historical texts https://www.lib.cam.ac.uk/genizah-fragments/posts/throwback-thursday-uncovering-karaites
Comment 4 Eyal Rozenberg 2023-04-01 22:49:17 UTC
Wow, I didn't realize the Qaraaites used Hebrew Nikkud on Arabic letters!

Reminds me a bit of how Maimonides wrote "Arabized" Hebrew - in Hebrew script, but using a lot of noun and verbs borrowed from Arabic rather than biblical Hebrew.
Comment 5 Commit Notification 2023-04-01 23:52:38 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/96aad0d0497c8486f8affc8fed79e63a060c9a59

tdf#154549: Make combining marks inherit the script of their base

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-04-02 20:43:22 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/68c9de338fffcd564da990b88fe7119880339df7

tdf#154549: Make combining marks inherit the script of their base

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-04-05 18:44:40 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8c3e219a831719ebb40dd2af8a26b0a24ad7aba1

tdf#154549: vcl_pdfexport: Add unittest

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.