Bug 154575 - Hide "Update entry from selection" icon in "Edit Index Entry" dialog
Summary: Hide "Update entry from selection" icon in "Edit Index Entry" dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: TableofContents-Indexes-Dialog
  Show dependency tree / graph
 
Reported: 2023-04-02 22:06 UTC by sdc.blanco
Modified: 2023-10-25 13:56 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Test file to demonstrate problem (14.58 KB, application/vnd.oasis.opendocument.text)
2023-04-02 22:06 UTC, sdc.blanco 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2023-04-02 22:06:24 UTC 
Created attachment 186421 [details]
Test file to demonstrate problem

1. Use "Edit Index Entry".
2. Select a text string in the document.
3. Click on "Update entry from selection" icon.
   Actual: "Apply to all similar texts" is activated.
4. Click on "Ok"

Actual:  Nothing happens.
Expected:  Either (a) “Update entry from selection“ is not shown for “Edit Index Entry“  (probably the "right answer"), or (b) that it is possible to insert an updated entry (and apply to similar texts).

The attached document provides some index entries and some similar words, with instructions about how to experience the actual behavior.

Probable resolution:

1. "Update entry from selection" icon should not be shown in the "Edit Index Entry" dialog.
2. The three options for text selection should not be shown.

Also tested with 7.6.0.0.alpha0+
Comment 1 Buovjaga 2023-04-05 13:07:13 UTC 
(In reply to sdc.blanco from comment #0)
> Created attachment 186421 [details]
> Test file to demonstrate problem
> 
> 1. Use "Edit Index Entry".
> 2. Select a text string in the document.
> 3. Click on "Update entry from selection" icon.
>    Actual: "Apply to all similar texts" is activated.

For me, it is not activated as in checked, but it does appear with some other checkboxes and kind of ruins the layout of the dialog.

> 4. Click on "Ok"
> 
> Actual:  Nothing happens.

Yes, clicking OK does nothing.

The icon was added with b7060e96dfef8e672ae954eb435a9513400c4ea9 in the context of bug 87686.

Heiko recently touched the .ui with 0f9226287fec770c4c9c0fe49b1d7046d995a3e9, so adding him for now.
Comment 2 sdc.blanco 2023-04-05 14:39:45 UTC 
(In reply to Buovjaga from comment #1)

Thanks for helpful detailed archaeology!

> For me, it is not activated as in checked, but it does appear with some
> other checkboxes and kind of ruins the layout of the dialog.
reported in bug 154209
Comment 3 Heiko Tietze 2023-05-25 09:29:02 UTC 
“Update entry from selection“ refreshes the Entry field according the current selection (the dialog is amodal). There is no point in showing this option in edit mode. 

By hiding it we would solve bug 154209 probably as well.
Comment 4 sdc.blanco 2023-05-25 09:36:48 UTC 
(In reply to Heiko Tietze from comment #3)
> By hiding it we would solve bug 154209 probably as well.
+1

Maybe this is an EasyHack?
Comment 5 sdc.blanco 2023-06-27 11:46:12 UTC 
Updating summary per comment 3
Comment 6 Jerry Ege 2023-06-27 11:51:39 UTC Comment hidden (spam)