Bug 154624 - macOS dark mode with Graphite accent colour makes selections unreadable (white on white)
Summary: macOS dark mode with Graphite accent colour makes selections unreadable (whit...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.2.2 release
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 155185 156460 (view as bug list)
Depends on:
Blocks: macOS-Dark-Mode
  Show dependency treegraph
 
Reported: 2023-04-05 15:53 UTC by Lucas Vieites
Modified: 2024-07-05 23:23 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Styles pane in dark mode with white text on white background (284.24 KB, image/png)
2023-04-05 15:54 UTC, Lucas Vieites
Details
Options dialog window with selected section in white text with white background (132.69 KB, image/png)
2023-04-05 15:55 UTC, Lucas Vieites
Details
MacOS settings: General > Highlight color, with the "Other" option selected. (49.52 KB, image/png)
2023-04-20 09:33 UTC, Lucas Vieites
Details
Issues with Libra Office Light Mode when other highlight setting(grey) in Mac OS (247.33 KB, image/png)
2023-05-17 10:00 UTC, pbatty
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Vieites 2023-04-05 15:53:49 UTC
Description:
When running LO 7.5.2.2 (also on earlier 7.5 releases) and opening the Styles pane on a Writer document, the highlighted style has white text on white background, rendering it unreadable.
This also happens in the Preferences (Options) dialog.
Screenshots provided in this bug report.

Steps to Reproduce:
1. Open LibreOffice Writer on macos in dark mode
2. Display the Styles pane (Command + Alt + 2)
3. Select any of the styles


Actual Results:
The selected style name is in white, with white background

Expected Results:
The selected style should be readable according to the selected theme


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 12; OS: Mac OS X 12.6.3; UI render: default; VCL: osx
Locale: en-US (en_NL.UTF-8); UI: en-US
Calc: threaded
Comment 1 Lucas Vieites 2023-04-05 15:54:41 UTC
Created attachment 186490 [details]
Styles pane in dark mode with white text on white background
Comment 2 Lucas Vieites 2023-04-05 15:55:23 UTC
Created attachment 186491 [details]
Options dialog window with selected section in white text with white background
Comment 3 Buovjaga 2023-04-11 11:49:02 UTC
As many fixes have still been going in, can you check also with a fresh unstable build: https://dev-builds.libreoffice.org/daily/master/current.html
MacOSX-x86_64@tb94-TDF seems the best for you at the moment.

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED WORKSFORME, if the problem went away.
Comment 4 Lucas Vieites 2023-04-13 13:30:44 UTC
(In reply to Buovjaga from comment #3)
> As many fixes have still been going in, can you check also with a fresh
> unstable build: https://dev-builds.libreoffice.org/daily/master/current.html
> MacOSX-x86_64@tb94-TDF seems the best for you at the moment.
> 
> Set to NEEDINFO.
> Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED
> WORKSFORME, if the problem went away.

Hi Buovjaga, I have tried with MacOSX-x86_64@tb94-TDF and this issue is still present.
Comment 5 Stéphane Guillou (stragu) 2023-04-19 21:48:40 UTC
I tested with:

Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 2; OS: Mac OS X 13.2.1; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

and:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc6806c4be8585ce0d35a6b581bf8b3dbf858500
CPU threads: 2; OS: Mac OS X 13.2.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I could not reproduce with the default macOS appearance settings (the selection highlight colour is blue), but changing the accent colour to Graphite shows the same issue as in your screenshot.

Lucas, can you please confirm that you are using the Graphite accent colour?

Patrick, have you worked with accent colours before?
Comment 6 Lucas Vieites 2023-04-20 09:33:39 UTC
I am, indeed, using the Graphite accent. When I switch to any other predefined color, the highlight works fine.
Only selecting "Graphite" has the result I describe in this bug.

I found a workaround: select the "Other" option and choose a grey color.
Comment 7 Lucas Vieites 2023-04-20 09:33:54 UTC
Created attachment 186808 [details]
MacOS settings: General > Highlight color, with the "Other" option selected.
Comment 8 pbatty 2023-05-17 09:55:06 UTC
I am sorry for the delay I was away for a few day. To answer your question the answer is YES my Mac OS highlight colour was set to Graphite. If I select other (grey) or any other colour the issue disappears. 

However, if you set the Mac OS to use other (Grey) then set LibreOffice to Light mode the situation is even worse!
Comment 9 pbatty 2023-05-17 10:00:56 UTC
Created attachment 187348 [details]
Issues with Libra Office Light Mode when other highlight setting(grey) in Mac OS

I used the settings discussed by others, then played with LibreOffice settings for the view (system, Dark & Light) to see what happened. Using the light setting results in lots of information and icons being invisible!
Comment 10 Stéphane Guillou (stragu) 2023-05-17 11:45:06 UTC
*** Bug 155185 has been marked as a duplicate of this bug. ***
Comment 11 Heiko Tietze 2023-05-26 08:43:09 UTC
The row/col header uses the Accent color now but if highlight is set to Graphite it still is drawn as white with white font color for the dark appearance.
Comment 12 Heiko Tietze 2023-05-30 09:07:21 UTC
Tried to solve the issue by using the Accent color but this approach is not ideal.

Graphite returns in vcl/osx/salframe.cxx at static Color getColor() the value pRBGColor:0x56988317d1e67683 in case of [NSColor selectedTextBackgroundColor] (#1391), which is then converted in getRed to r:1, g:1, b:1 and alpha:0.247059.

Any other color works well.
Comment 13 Stéphane Guillou (stragu) 2023-07-26 10:16:37 UTC
*** Bug 156460 has been marked as a duplicate of this bug. ***
Comment 14 Stéphane Guillou (stragu) 2024-01-08 23:04:26 UTC
(In reply to pbatty from comment #9)
> Created attachment 187348 [details]
> Issues with Libra Office Light Mode when other highlight setting(grey) in
> Mac OS
I think this is more about the lack of refresh until restart, see bug 156855.