Bug 154698 - Writer XML Form: "XML Form Document" in title bar is not localised
Summary: Writer XML Form: "XML Form Document" in title bar is not localised
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
7.4.6.2 release
Hardware: All All
: low trivial
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: XML_Form
  Show dependency treegraph
 
Reported: 2023-04-07 10:45 UTC by lol
Modified: 2023-05-03 07:15 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
title bar XML Form Document (9.88 KB, image/png)
2023-04-07 10:45 UTC, lol
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lol 2023-04-07 10:45:26 UTC
Created attachment 186531 [details]
title bar XML Form Document

In the title bar of a XML Form Document the words "XML Form Document" are not localised. See attached picture.
Comment 1 lol 2023-04-07 10:53:54 UTC
Forget the version info:

Version: 7.4.6.2 (x86) / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 2 Robert Großkopf 2023-04-07 15:25:05 UTC
Isn't "XML Form Document" the same as the "Writer", "Calc" … No title for this kind of documents has been localized. Also "Writer/Web" couldn't be localized.
Comment 3 Buovjaga 2023-04-12 14:30:12 UTC
Caolán commented in the chat:

I would *guess* this is "XML Form Document" as ooSetupFactoryUIName in officecfg/registry/data/org/openoffice/Setup.xcu which is just "<value>XML Form Document</value>" but I see there is <value xml:lang="en-US">Base: Data View</value> for ooSetupFactoryUIName for base, so I suspect it could be make localizable with xml:lang="en-US"
Comment 4 Buovjaga 2023-04-12 14:30:53 UTC
One more note from Caolán:
 4e7e737c111698f32c8b81e2a73f828db02c60ef is a sample commit that has an example of some of these apparently localizable ooSetupFactoryUIName which is what I speculate ends up in the title bar
Comment 5 Commit Notification 2023-04-24 14:04:57 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a27e9e32ca9d67402706d1d970f3aaa04d746904

tdf#154698 allow "XML Form Document" to be localized

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 lol 2023-05-03 07:12:42 UTC
Verified. Checked with

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 607b85b908d14f9907e12932bbc2298398f72ef0
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
Comment 7 lol 2023-05-03 07:15:40 UTC
Thanks for implementing this!