Bug 154825 - Edit Sections: Hide Status is not reflected in Icons (hidden/unhidden) except Karasa Jaga and Sukapura
Summary: Edit Sections: Hide Status is not reflected in Icons (hidden/unhidden) except...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.5.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0 target:7.5.4
Keywords:
Depends on:
Blocks: Icon-Themes
  Show dependency treegraph
 
Reported: 2023-04-15 12:47 UTC by Kai Struck
Modified: 2023-07-09 16:12 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Edit Sections dialog LO5 reflecting hide status (18.52 KB, image/png)
2023-04-15 12:49 UTC, Kai Struck
Details
Edit Sections dialog LO6 hide status not reflected (28.11 KB, image/png)
2023-04-15 12:49 UTC, Kai Struck
Details
example document odt (9.64 KB, application/vnd.oasis.opendocument.text)
2023-04-15 12:50 UTC, Kai Struck
Details
For further testing, I set some section to be write protected (11.04 KB, application/vnd.oasis.opendocument.text)
2023-04-21 06:36 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Struck 2023-04-15 12:47:15 UTC
Description:
When editing Sections with right click in the Navigator->Sections->edit the hide status isn't anymore reflected in the icons as it was in LibreOffice up to version 5

Steps to Reproduce:
1.In example file: go to Navigator, right click on a sections, choose "edit"
2.The hidden Sections should have another icon than the unhidden


Actual Results:
The hidden Sections have the same icon as the unhidden

Expected Results:
The hidden Sections should have another icon than the unhidden


Reproducible: Always


User Profile Reset: No

Additional Info:
This behavior started with Version 6 I think
Comment 1 Kai Struck 2023-04-15 12:49:03 UTC
Created attachment 186681 [details]
Edit Sections dialog LO5 reflecting hide status
Comment 2 Kai Struck 2023-04-15 12:49:54 UTC
Created attachment 186682 [details]
Edit Sections dialog LO6 hide status not reflected
Comment 3 Kai Struck 2023-04-15 12:50:29 UTC
Created attachment 186683 [details]
example document odt
Comment 4 Buovjaga 2023-04-20 12:12:08 UTC
The file is sw/uiconfig/swriter/ui/editsectiondialog.ui

Rizal: maybe you can look into it for the other themes. I could not quickly locate the icon names.
Comment 5 Rizal Muttaqin 2023-04-21 01:42:29 UTC
(In reply to Buovjaga from comment #4)
> The file is sw/uiconfig/swriter/ui/editsectiondialog.ui
> 
> Rizal: maybe you can look into it for the other themes. I could not quickly
> locate the icon names.

I can see that Karasa Jaga used copied version of previous Galaxy as KJ was meant to be complete as possible. Here the icon files list:

icon-themes/<icon-theme-name>/sw/res/re01.<png/svg>
icon-themes/<icon-theme-name>/sw/res/re02.<png/svg>
icon-themes/<icon-theme-name>/sw/res/re03.<png/svg>
icon-themes/<icon-theme-name>/sw/res/re04.<png/svg>
Comment 6 Rizal Muttaqin 2023-04-21 06:36:48 UTC
Created attachment 186828 [details]
For further testing, I set some section to be write protected
Comment 7 Commit Notification 2023-04-21 08:59:19 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dd0b469af4b1ab49faf4b1688932da2370368e70

Colibre tdf#154825 Section editor icons

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-04-23 14:32:13 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4ee01c29a3794e1e0dee300d0f2aa150ce07b3c0

tdf#154825 All icon themes: add/update section editor

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-04-23 16:46:37 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/e58f64301122f71abf8260bbe5bbcd5846269351

tdf#154825 All icon themes: add/update section editor

It will be available in 7.5.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.