Bug 154933 - Rename "Text body" to "Body text"
Summary: Rename "Text body" to "Body text"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0 target:24.2.0 target:7.6...
Keywords:
Depends on:
Blocks: Writer-Styles
  Show dependency treegraph
 
Reported: 2023-04-20 13:49 UTC by Tuomas Hietala
Modified: 2024-02-06 09:48 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Document that renders wrongly in LO 7.6 and 20.2 (22.37 KB, application/vnd.oasis.opendocument.text)
2024-02-04 01:25 UTC, Kenneth Burke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2023-04-20 13:49:27 UTC
Description:
LO has a paragraph style called "Text body", which refers to what is commonly called "body text" in English: https://en.wikipedia.org/wiki/Body_text

I'm not aware of "text body" being used outside of LO, so I suggest the strings in LO should be changed to "body text".

See also bug #153735 (fixed, but only some of the strings featuring "text body" were changed).


Steps to Reproduce:
n/a


Actual Results:
"Text body" is used in LO.

Expected Results:
"Body text" is used in LO.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Tuomas Hietala 2023-04-20 13:56:58 UTC
Also, there's a style called "Text Body Indent", which in more proper English would be something like "Indented Body Text", or "Body Text, Indented".
Comment 2 Rafael Lima 2023-04-20 22:22:48 UTC
+1 from my side.

Apparently "body text" is the right choice here.
Comment 3 Heiko Tietze 2023-04-21 06:50:46 UTC
Recently discussed at bug 153735 in respect to the outline level (renamed from "Text Body" 
to "None").
Comment 4 Heiko Tietze 2023-05-10 15:46:32 UTC
Style name "Text body" is spread over application in so many UI tests, importers, mappers etc. Abandoned https://gerrit.libreoffice.org/c/core/+/151310
Comment 5 Xisco Faulí 2023-05-11 07:27:15 UTC
(In reply to Heiko Tietze from comment #4)
> Style name "Text body" is spread over application in so many UI tests,
> importers, mappers etc. Abandoned
> https://gerrit.libreoffice.org/c/core/+/151310

you can just adapt the tests
Comment 6 Commit Notification 2023-05-11 09:21:38 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c83d241effbd09491e9f96d3e435ab91700f58b0

tdf#154933 Rename "Text Body" para style to "Body Text"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-05-11 16:59:36 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/47fc6a5805592dc4e6b5339def60e2b0727a30eb

tdf#154933 Rename "Text Body" to "Body Text" in menus

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 BogdanB 2023-05-11 19:13:18 UTC
In Styles and Menus is ok.

Verified with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c8cb7a658b33e296024044f3377378644a9a97ef
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 9 Commit Notification 2023-06-08 20:21:25 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/430c011fc24671011cbdd5f6310e7681ecdaf17d

Related tdf#154933  update "Text Body" -> "Body Text"
Comment 11 Commit Notification 2023-06-11 21:47:41 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7fa6198f29ac18ef2d58129918cb76c5da263d4f

tdf#154933 Update style names in autocorrect strings

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-06-12 20:56:29 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/f6cb83f87865c2b5729c823a9ccb7b3d4404d7c0

tdf#154933 Update style names in autocorrect strings

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2023-06-17 23:18:55 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/help/commit/dc45fbe8e459de068be8370757affb486b4aafad

Related tdf#154933  update "Text Body" -> "Body Text"
Comment 14 Olivier Hallot 2023-06-19 14:22:58 UTC
4 more occurences of "text body" in Help....

olivier@olivier-ntbk:~/tmp2/help/source$ git grep -i text\ body

text/shared/01/06040100.xhp:      <note xml-lang="en-US" id="par_id7547227">All non-empty paragraphs with "Default Paragraph Style" are converted to "Text Body" paragraph style when <menuitem>Tools - AutoCorrect - Apply</menuitem> is used.</note> <comment>see i72339</comment><comment>Don't use inline switches for notes, tips and warnings. The icon will still show up.</comment>

text/shared/01/06040100.xhp:<note xml-lang="en-US" id="par_id3145606">The automatic numbering option is only applied to paragraphs that are formatted with the "Default", "Text body", or "Text body indent" paragraph style.</note>
text/shared/01/06040100.xhp:      <note id="par_id331611585252617">This feature works only with "Default Paragraph Style", "Text Body" and "Text Body Indent" paragraph styles, and there must be one empty paragraph before the text, if the text is not at the top of a page.</note>

text/shared/01/06040100.xhp:      <paragraph xml-lang="en-US" id="par_id3156299" role="paragraph"><switchinline select="appl"><caseinline select="WRITER">Replaces custom paragraph styles applied in the current document to "Text Body", "Text Body Indent", "First Line Indent" or "Hanging Indent" paragraph style.

text/shared/optionen/01041000.xhp:<paragraph role="paragraph" id="par_id7280190" xml-lang="en-US">In Microsoft Word and in current versions of Writer, page header/footer content and footnote/endnote content does not wrap around floating screen objects. Text body content wraps around floating screen objects which are anchored in the page header. </paragraph>
text/swriter/01/mailmerge05.xhp:<h3 id="par_idN10556">Align to text body</h3>
Comment 15 sdc.blanco 2023-06-19 14:29:02 UTC
(In reply to Olivier Hallot from comment #14)
> 4 more occurences of "text body" in Help....
I was planning to address those this week.  The last one is not relevant. The other three are on the same AutoCorrect page, which may need some other changes, because bug 90507 was fixed recently.
Comment 16 Commit Notification 2023-06-25 22:11:00 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/62a280c3b288b30ac34f68e4665c76369336cda1

(related) tdf#90507,tdf#154933 Text Body -> Body Text
Comment 17 Commit Notification 2023-06-25 22:14:05 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/help/commit/a12f65df843f2cd8f2c6a04e41c981c753c3d5bf

(related) tdf#90507,tdf#154933 Text Body -> Body Text
Comment 18 Kenneth Burke 2024-02-04 01:25:17 UTC
Created attachment 192376 [details]
Document that renders wrongly in LO 7.6 and 20.2

The line AAAA in the sample document renders differently in LO 7.5.9 than it does in later versions of LibreOffice Writer. When the Text Body paragraph style in LO 7.5.9 and earlier is changed to Body Text in LO 7.6 and later the style properties change as below:
With LO 7.5.9.2
Font Charis SIL Compact 11 pt
Spacing below paragraph 8.0 pt
Line spacing fixed 13.5 pt

With LO 20.2
Font Charis SIL Compact 10 pt
Below paragraph 5.8 pt
Line spacing fixed 11.5
Comment 19 Heiko Tietze 2024-02-05 12:33:07 UTC
Where exactly do you spot a difference? The change was just a renaming, at least in this patch.

I'm comparing 

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Mac OS X 14.3; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded

and

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7a3e9c66baff8554d1267bc98c9c69e763bc8bdc
CPU threads: 8; OS: macOS 14.3; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded

(the special font Charis SIL Compact is not installed on my system)
Comment 20 Kenneth Burke 2024-02-05 23:54:11 UTC
Thank you for responding to my post. I should also let you know I opened a separate bug report, number 159549, to report the same problem. I have read the instructions on how to file bug reports, but this is the first bug report I have submitted. Please be patient with me if I am not following proper protocol here.

As far as I can tell, for the test document the behavior is the same in LO version 7.6.2 and version 24.2. I have not tested LO 24.8.0.0.alpha0+. The altered behavior of some paragraphs occurs between LO 7.5.9 and LO 7.6 and later versions.

After I uploaded the document I found it contains in its original version (as created by LO version 7.5.9) both a paragraph style named "Text Body" and another style named "Body Text." The "Body Text" style was listed as hidden and was not used by any paragraphs in the document when loaded by LO 7.5.9 and earlier. The 2 paragraph styles have different settings. When the document is opened in LO 7.6 and later, paragraphs originally given the Text Body style are re-assigned to the Body Text style and take on the settings of the Body Text style. This alters the properties of those paragraphs.

As a workaround when creating future documents it would seem my team could substitute the Body Text style with desired settings instead of the Text Body style. The problem for us is the hundreds of existing documents that have Text Body and Body Text styles coexisting in the same document. If LibreOffice Writer could be made to check to see if both styles exist in the same document and then leave Text Body in place when it finds both present, that might help avert the problem my office has encountered.

Thank you again for looking into this problem.
Comment 21 Heiko Tietze 2024-02-06 09:47:47 UTC
(In reply to Kenneth Burke from comment #20)
> Thank you for responding to my post. I should also let you know I opened a
> separate bug report, number 159549, to report the same problem. I have read
> the instructions on how to file bug reports, but this is the first bug
> report I have submitted. Please be patient with me if I am not following
> proper protocol here.
Thanks a lot for taking the time for reporting issues! Let's handle the issue in your follow-up ticket; I'm still not convinced it's a real problem since style names should not affect templates. But let's see what QA finds out.