Bug 154951 - Accessibility checker does not warn about missing alt text of grouped shapes
Summary: Accessibility checker does not warn about missing alt text of grouped shapes
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2
Keywords: accessibility
Depends on:
Blocks: Accessibility-Check
  Show dependency treegraph
 
Reported: 2023-04-21 09:49 UTC by Gabor Kelemen (allotropia)
Modified: 2023-07-05 21:01 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
example file from Writer (11.54 KB, application/vnd.oasis.opendocument.text)
2023-04-21 09:49 UTC, Gabor Kelemen (allotropia)
Details
The sidebar without any warning about missing description (46.00 KB, image/png)
2023-04-21 09:51 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-04-21 09:49:13 UTC
Created attachment 186834 [details]
example file from Writer

Attached file contains two grouped shapes. The group of the blue rectangles has its alt text filled - see Format - Description - but the group of the green shapes has it empty.
The accessibility sidebar does not warn about this missing.

1. Open attached file
2. Open the accessibility sidebar 
-> there is no warning about the missing description of the group.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 61b41646c5a93ca24f2c9f143cdb0da2c9258989
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2023-04-21 09:51:42 UTC
Created attachment 186835 [details]
The sidebar without any warning about missing description
Comment 2 Stéphane Guillou (stragu) 2023-04-21 10:54:09 UTC
Reproduced with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Creating two shapes will eventually show two warnings about descriptions missing for them. Grouping them make the warnings disappear, and there is no new warning for the group.

Gabor, regarding grouped shapes exported to an accessible PDF, do you think the fix should warn about individuals + group (3 description warnings), or only for the group (one single warning)?
Comment 3 Commit Notification 2023-06-08 15:07:47 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0b98ddee3612568ac640ad05b2d3d59f00d9ca2f

tdf#154951 - Accessibility checker fix missing alt text of grouped shapes

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-06-08 20:18:21 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/f0619fddd49b56652f2fed9a2b56d21a2769e3b0

tdf#154951 - Accessibility checker fix missing alt text of grouped shapes

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Stéphane Guillou (stragu) 2023-07-05 21:01:20 UTC
Fix verified in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d74344f6cae0cf1c12f08249c8f49be1374fb98f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded