Description: Note: this has been tested on 7.5.3.1 prerelease, but there is no option for that version in the drop down. When running spell check in Writer, if the spell checker doesn't find anything it doesn't display the spell check language. Steps to Reproduce: 1. Open attached file. 2. Run spell check. 3. Accept or ignore any suggestions which may pop up. 4. Close spell check. 5. Run spell check again. Actual Results: The drop down for the text language in the spell check tool displays [none]. Expected Results: The drop down for the text language in the spell check tool displays the correct language, English (UK) in this case. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.3.1 (X86_64) / LibreOffice Community Build ID: d29ee673721b12c92b3de9b9663473211414f0db CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: threaded
Created attachment 186930 [details] Test document Document to test the issue.
But which language should it display in this case? A document with all the text having a single language is just a special case, and even then, it is absolutely unrelated to what the dialog shows. In general, the dialog shown the language assigned to the *detected error*, because that language determines e.g. which user-defined dictionary to use to add the word, or to change the language of the erroneously found case; and when there is no such error, the dialog has nothing to show. What exact problem would it solve, if it shown a randomly chosen language?
In my opinion, if the entire text is in one language, the spell check language should display that language, even if it detects no mistakes. It's not a problem, just a trivial cosmetic issue. (Hence the bug importance being put as trivial.)
Again: the dialog displays not the language of a document, but the language of currently processed error. No currently processed error - no language. Displaying unrelated information (like "we detected that there was only one language, so we show it to you as a bonus") is not a cosmetic improvement, but would be an own problem: what the shown language means? Why it doesn't show in other cases? how does it change user's actions? NOTABUG.
Heiko: do you think it would be reasonable to change the label wording here, from the confusing "Text language" (which likely provoked this issue), to something like "Fragment language"? Also, the dialog shown after the spell check completes (without anything selected) should have everything disabled - the language selector, among with the "add to dictionary"/"ignore" buttons. Indeed, this is a separate issue, just thought I mention it until I forget :)
"Emily Wilson haz a secret" returns "English (UK)", the correct sentence nothing. I can follow the question. The point is that <en-gb>Emily Wilson haz a secret</en-gb>: <en-us>she's a garl.</en-us> shows "English (UK)" and "English (USA)" for the typos. But without typos I still have some language. Most text will be the exception and use only one language, the other 10% probably understand the switch from one to the other. And "Fragment language" or anything else seems to bring more confusion to the user. I would show the language at the cursor position, which should match the default / all text setting.
(In reply to Heiko Tietze from comment #6) > But without typos I still have some language. So what? Please understand that you also might have a car, and showing its model here could also be an option to show an unrelated info. > Most text will be the exception and use only one language, the other 10% > probably understand the switch from one to the other. So you suggest to replace something consistent, with something that *affected users should **probably** understand*? > And "Fragment language" or anything else seems to bring more confusion to the user. Really seems? How? :) > I would show the language at the cursor position, which should match the > default / all text setting. Sigh.