Bug 155049 - "X.509" in dialog title when signing or encrypting ODF file
Summary: "X.509" in dialog title when signing or encrypting ODF file
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) alpha1+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
Whiteboard: target:7.6.0
Keywords: implementationError
Depends on:
Blocks: Digital-Signatures
  Show dependency treegraph
Reported: 2023-04-27 14:06 UTC by Stéphane Guillou (stragu)
Modified: 2023-05-03 07:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-04-27 14:06:29 UTC
The dialogs for signing or encrypting an ODF file both show "X.509" in the title when it's not restricted to that certificate type.

1. Open Writer or Calc, save file in an ODF format
2. File > Digital Signatures > Digital Signatures... > Sign document

Dialog title is "Select X.509 Certificate" even though OpenPGP keys can be used.

Same thing after File > Save as > "Encrypt with GPG key" ticked > Save. Encrypting should only work with OpenPGP keys: https://help.libreoffice.org/7.6/en-US/text/shared/guide/openpgp.html

No mention of X.509 in the two dialogs' titles as other types can be selected.

Bibisected with linux-64-7.2 repo to first bad commit a25d8b36361871c06b0b938cb438739e3c755450 which points to core commit:

commit a1146fd95022196636f8c41f7322a7257955cef4
author	Vishwas <19ucc001@lnmiit.ac.in>	Tue Jan 05 18:30:45 2021 +0530
committer	Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>	Wed Jan 27 12:13:50 2021 +0100
tdf#115884 PDF signing should mention it only works with x509 certificates
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108805

Vishwas hasn't been active in the last year.
Buovjaga, what do you think?
Comment 1 Andrew Watson 2023-05-02 09:12:46 UTC
Bug confirmed present in:

Version: / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

Set status to NEW.
Comment 2 Commit Notification 2023-05-02 12:55:28 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":


tdf#155049 Revert "tdf#115884 PDF signing should mention

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.