Bug 155066 - Theme colors palette is blank
Summary: Theme colors palette is blank
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.4.6.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Color-Palettes
  Show dependency treegraph
 
Reported: 2023-04-28 14:09 UTC by Don Matschull
Modified: 2023-05-01 06:24 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Showing blank theme palette in example document with theme (178.02 KB, image/jpeg)
2023-04-28 23:32 UTC, Don Matschull
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Don Matschull 2023-04-28 14:09:39 UTC
If I try to change the color palette in either the Fill Color or Line Color dialogs, both the Theme colors and Document colors dialogs are blank and I can find no way to populate them.
Comment 1 Stéphane Guillou (stragu) 2023-04-28 21:08:05 UTC
The empty Theme colors palette is expected as it is only populated when the document uses a theme. See the documentation page:
https://help.libreoffice.org/7.6/en-US/text/shared/01/05210200.html
An example document with a theme: attachment 185462 [details]

However, you are right that the Document colors palette does not populate as expected in Draw.

I can already see the issue back in 6.0:

Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group

And still in a recent master build:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 424bdeda9fea09f0b48b5551baf872656845c7c3
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

It's already reported in bug 116782, so marking as duplicate.

*** This bug has been marked as a duplicate of bug 116782 ***
Comment 2 Don Matschull 2023-04-28 23:32:18 UTC
Created attachment 186994 [details]
Showing blank theme palette in example document with  theme
Comment 3 Don Matschull 2023-04-28 23:38:34 UTC
The example document with theme is a Writer document rather than a Draw document. Even so, the Theme colors palette is blank as seen in the attachment.

The only references to theme in the Writer Guide and Draw Guide are to themes in the Gallery, not to the Theme colors palette.
Comment 4 Robert Großkopf 2023-04-29 09:30:26 UTC
Them color will appear in 
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cb79692883e92de02d87b0662a431f6ff8fba9c8
CPU threads: 6; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

I couldn't see this Theme colors in LO 7.5.3.2 or earlier versions.

I will set this one to NEW. We could switch it to WONTFIX, if there aren't bugfixes available for LO 7.5 any more.
Comment 5 V Stuart Foote 2023-04-29 15:32:14 UTC
Can not confirm at 7.6 where the loext:name="Office Theme" stanzas are being written to ODF archives.

20230428 TB77
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2eb3922750b385dcadfd124d7baf686cec40eb5e
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

On recent master attachment 185462 [details] opens and the "Document colors" palette shows the two used colors ("Document color 1", "Document color 2") while the "Theme colors" palette is present and those colors correspond to the theme "Text - Light 2, 50% darker" and "Accent 6, 60% lighter" respectively--i.e. as applied to document the color swatch matches value with the "Theme color" palette.

Usability issue is less that parsing the default "Theme colors" palette is not supported pre-7.6.0, rather that for a document prepared with any palette including "Theme colors" there still is no handling of the "Document colors" coming from draw shapes and other area fills already in that document. 

That is as in bug 116782c#1, but not clear anything can be done for 7.5, certainly nothing for 7.4

IMHO => WF
Comment 6 Stéphane Guillou (stragu) 2023-04-29 21:28:02 UTC
OK, let's focus on the Theme colors palette only (as the empty Document colors palette is already tracked elsewhere):

Thomasz and Regina, I'm not sure if Theme colors will ever apply to ODG, but should the palette be hidden from the dropdown if the document does not use a theme / the format does not support storing such information?
Comment 7 Stéphane Guillou (stragu) 2023-04-29 21:29:23 UTC
(In reply to Stéphane Guillou (stragu) from comment #6)
> Thomasz and Regina

(Tomaž, sorry)
Comment 8 Regina Henschel 2023-04-30 00:41:45 UTC
(In reply to Stéphane Guillou (stragu) from comment #6)
> OK, let's focus on the Theme colors palette only (as the empty Document
> colors palette is already tracked elsewhere):
> 
> Thomasz and Regina, I'm not sure if Theme colors will ever apply to ODG, but
> should the palette be hidden from the dropdown if the document does not use
> a theme / the format does not support storing such information?

Themes are written in loext-namespace to odp and work in the UI in Impress. Impress and Draw have so many things in common, that I see no reason, why theme colors should not work in Draw. I see, that the color palette is blank in Draw and for me that is simply an error or a not yet finished implementation. So the report should be "New", either as bug or as enhancement. 'wontfix' is not appropriate.
Comment 9 Stéphane Guillou (stragu) 2023-04-30 07:09:57 UTC
Thanks Regina.
I wasn't aware that a theme should be visible straight from startup once implemented.
I can now see it in a master build from today:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dd15364793401e41bae45cdeb410808c9f94fa93
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

So marking as resolved.

Can others confirm the Theme colors palettes works with https://dev-builds.libreoffice.org/daily/master/current.html
Comment 10 Stéphane Guillou (stragu) 2023-04-30 07:21:38 UTC
Theme palette is visible in Draw since:

commit c3f7720ff13c34b9cf2c90d9c9b6dcc3d8f4c7a5
author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	Thu Mar 23 11:37:40 2023 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	Mon Apr 24 23:49:57 2023 +0200
oox: extend ThemeExport to export font and format scheme of a theme
Also use the ThemeExport when exporting PPTX documents and remove
all the hard-coded theme bits.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149363

Marking as fixed.
Tomaž, I assume there's too many large associated theme changes to backport to 7.5, is that correct?
Comment 11 Tomaz Vajngerl 2023-05-01 06:24:10 UTC
No, it makes no sense to fix this for 7.5 - the theme support there is minimal (only in impress).