Bug 155426 - FILESAVE PPTX PowerPoint wants to repair the specific file after roundtrip
Summary: FILESAVE PPTX PowerPoint wants to repair the specific file after roundtrip
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: PPTX-Corrupted OOXML-Doc-Themes
  Show dependency treegraph
 
Reported: 2023-05-21 12:13 UTC by Regina Henschel
Modified: 2023-06-21 07:39 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
file to reproduce the error (45.13 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2023-05-21 12:13 UTC, Regina Henschel
Details
fdo71434.pptx (151.95 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2023-05-21 12:14 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2023-05-21 12:13:31 UTC
Created attachment 187417 [details]
file to reproduce the error

Open the attached file and resave it to pptx. Open the saved file in PowerPoint. It wants to repair it.
This error still exists after the missing typeface attributes (bug 155412) are fixed.

The export was correct in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4829a85d0753c93419bd46b1d50bcfa6f0f3f1da
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL threaded

The OOXML Validator extension for VS Code reports a problem with the package, "Specified part does not exist in the package."

The same problem is with the file fdo71434.pptx.
The two files are from https://opengrok.libreoffice.org/xref/core/sd/qa/unit/data/
Comment 1 Regina Henschel 2023-05-21 12:14:26 UTC
Created attachment 187418 [details]
fdo71434.pptx
Comment 2 m_a_riosv 2023-05-21 16:14:12 UTC
Sorry, I was opening fdo47434.pptx in PP without save first with LibreOffice.

For fdo47434.pptx, still to me with:
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1fec168aff4569827d4822c9fcff7bc4ecd0d04b
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Comment 3 Regina Henschel 2023-05-21 17:51:26 UTC
(In reply to m.a.riosv from comment #2)
> Sorry, I was opening fdo47434.pptx in PP without save first with LibreOffice.
> 
> For fdo47434.pptx, still to me with:
> Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
> Build ID: 1fec168aff4569827d4822c9fcff7bc4ecd0d04b
> CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL:
> win
> Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

That build does not contain the fix for bug 155412.
The files in question here are fdo71434.pptx and n762695.pptx.

The file [Content_Types].xml should provide the "ContentType" for all files contained in the package. For fdo71434.pptx I see entries missing for the files:
ppt/tableStyles.xml
ppt/viewProps.xml
ppt/handoutMasters/handoutMaster1.xml
ppt/slideLayouts/slideLayout13.xml
ppt/slideLayouts/slideLayout14.xml

I think, the ".rels" files need not be listed, because their "ContentType" is covered by <Default Extension="rels" ContentType="application/vnd.openxmlformats-package.relationships+xml"/>
Comment 4 Regina Henschel 2023-05-21 19:39:12 UTC
In n762695.pptx I find a Target="./theme/theme3.xml" in notesMaster1.xml.rels. Such file does not exist in the package.
Removing that element resolves the package error. But PowerPoint still wants to repair the file.
Comment 5 Aron Budea 2023-06-16 14:46:24 UTC
These both started from the following commit, bibisected using bibisect-linux-64-7.6. Adding CC: to Tomaž Vajngerl.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c3f7720ff13c34b9cf2c90d9c9b6dcc3d8f4c7a5
author		Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2023-03-23 11:37:40 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2023-04-24 23:49:57 +0200

oox: extend ThemeExport to export font and format scheme of a theme
Comment 6 Aron Budea 2023-06-17 01:23:17 UTC
A couple of other bugdocs that still can't be opened in PP after rountrip:
attachment 45416 [details] from bug 36076
attachment 60566 [details] from bug 37312
attachment 56446 [details] from bug 45497
attachment 74230 [details] from bug 60316
Comment 7 Aron Budea 2023-06-21 05:37:17 UTC
This was still buggy with yesterday's daily build, and is fine with today's, with the only possible fixing commit being:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b13733de130e2f1ca029315e977dc01bd196b05b
author		Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2023-06-20 17:39:40 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2023-06-20 13:14:48 +0200

"sd: fix setting theme for notes master"

Backport to 7.6: https://gerrit.libreoffice.org/c/core/+/153344

Thanks for fixing, Tomaž!
Comment 8 Aron Budea 2023-06-21 07:39:01 UTC
Patch to 7.6 is merged now.


https://cgit.freedesktop.org/libreoffice/core/commit/?id=6e75e18782051d174cb198e129a4d68fe0af9a33
author		Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2023-06-20 17:39:40 +0900
committer	Xisco Fauli <xiscofauli@libreoffice.org>	2023-06-21 08:54:11 +0200

"sd: fix setting theme for notes masterlibreoffice-7-6"

A note about this fix (the fix itself, not just the backport), there's a TODO for full support of themes in note master that is to be added in the future:
// TODO: Need to implement theme support for note master, so the
// note master has his own theme associated.