Description: Open a pptx with master slides that are not used. Only the used master slides will show up in Impress. Steps to Reproduce: 1. Open a pptx with unused master slides 2. Check the available master slides Actual Results: the unused master slides are not available for use. Expected Results: The unused master slides are avaible for use. Reproducible: Always User Profile Reset: No Additional Info: https://git.libreoffice.org/core/+/refs/heads/master/oox/source/ppt/presentationfragmenthandler.cxx loops on slides and loads their master and that's all.
Created attachment 187524 [details] Example document showing the issue
Seems like a duplicate of missinge feature in LO that consequently does not work for PPTX. If not so, please explain. *** This bug has been marked as a duplicate of bug 144459 ***
Henry Castro committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9fabd7c11989c2a89c5bb238e6cb52b0a6678851 tdf#155512: oox: ppt: abstraction "importMasterSlide" It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/adcde78935fb8ca2b93322aa3a558d0b3ccdbfad tdf#155512: oox: ppt: fix import master slides It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/89d6b13b8fa4edf5d1df79dded799c531c656652 tdf#155512: oox: ppt: abstraction "importMasterSlide" It will be available in 7.6.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/1b871b635c7f368d46a0cff96c059a4d53b257d6 tdf#155512: oox: ppt: fix import master slides It will be available in 7.6.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The import master slides were fixed, but our QA team found more issues when saving the document: "1. TDF attachment 187524 [details] is very complex, in MSO it has 19+21+7 slides, so 47 in total, CO 23.05 opens 40 slides. 2. Order of master slides is not the same in MSO and LO. "
Henry Castro committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d590f094ccd28ca449eff91692c2178058d5c621 tdf#155512: sd: filter: eppt: add "SlideLayout" property to Slide Master It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/a1b3d8d6e90923f2cd03a556afd09edc2d084475 tdf#155512: sd: filter: eppt: add "SlideLayout" property to Slide Master It will be available in 7.6.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f2ae8b934aaac7c444e8493ed5e8189c6ce63328 tdf#155512: oox: ppt: fix import master slides, follow up It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/32e6ef3834a0f96d7830719950de52c99aae0263 tdf#155512: sd: qa: unit: add unit test "testMasterSlides" It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/9925d34afafc714d9c9c26f295fb7f88493c071d tdf#155512: oox: ppt: fix import master slides, follow up It will be available in 7.6.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/41097d6168de85c183be1c8a014c7e85de624060 tdf#155512: sd: qa: unit: add unit test "testMasterSlides" It will be available in 7.6.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I think this can be closed now, the unused master slides are imported and exported ~correctly, after the fix to bug 157740 Further complaints are to be filed separately. Thanks Henry for the work!
Thank you! Verifying this is addressed with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f989ee32b35ee4f0750ae313d35d225d252d64d4 CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US and Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: 60(Build:1) CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US which both show 44 master slides. Cédric, do you concur?