Bug 155961 - cannot access the controls close to vertical scrollbar
Summary: cannot access the controls close to vertical scrollbar
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.3.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:24.2.2 target:7.6.6
Keywords: bibisected, bisected, regression
: 150656 155980 159298 159480 (view as bug list)
Depends on:
Blocks: GTK3 Sidebar-UI-UX
  Show dependency treegraph
 
Reported: 2023-06-21 12:10 UTC by Elmar
Modified: 2024-03-06 05:39 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
controls on rhs visible (42.92 KB, image/png)
2023-06-21 12:14 UTC, Elmar
Details
controls on rhs not accessible (35.13 KB, image/png)
2023-06-21 12:17 UTC, Elmar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elmar 2023-06-21 12:10:27 UTC
Description:
When there is a need to select a control close to the vertical scrollbar, it is impossible to do so.

Steps to Reproduce:
1.try to select the open dialog control in any section in the sidebar
2. 
3.

Actual Results:
the vertical scrollbar expands to obscure the control. (This used to happen with the colour pallet chooser, but that has now been overcome. THANK YOU!)


Expected Results:
should be able to access the control against the right edge, even when the scrollbar is present.


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-GB
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4ce43750e7878a813127bdc409d5251369d035f5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded
Comment 1 Elmar 2023-06-21 12:14:05 UTC
Created attachment 188040 [details]
controls on rhs visible
Comment 2 Elmar 2023-06-21 12:17:38 UTC
Created attachment 188041 [details]
controls on rhs not accessible

Note how the "open paragraph settings" control is not visible and thus accessible; as well as the "background colour" control is partially obscoured
Comment 3 Stéphane Guillou (stragu) 2023-06-21 21:46:32 UTC
Thank you Eimar!
Reproduced in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 66da786bdd4588b31755058acf46034c2056215c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

When the sidebar deck overflows vertically, placing the pointer in the centre of the "More options" cog icon of a section (that is used to open the corresponding dialog, for example next to the Character or Paragraph headings) reveals the scrollbar.
There should be more padding for those buttons.

No problem for other controls for me.

Not reproduced for kf5, qt5 or gen VCLs.

The "popup" scrollbar was added by Caolán sidebar weld with commit f9cf66b39ea00afc66ae79ca46cd9071f3598cb8 but back then, it was still possible to move the pointer over the centre of the cog icon without popping the scrollbar out.

It's only later that the controls started sneaking further behind the scrollbar:
bibisected with linux-64-7.2 repo to first bad commit 6785b89bdcfb2c59354a12cffd020a172f2209a2 which points to commit 4c8916fce009a1aee0e644fa62150a9279202a53 which is a cherrypick of:

commit 10ec02f6fe4cd2c29021b967c255ace3f71424b5
author	Caolán McNamara <caolanm@redhat.com>	Wed Oct 06 12:02:17 2021 +0100
committer	Caolán McNamara <caolanm@redhat.com>	Wed Oct 06 14:48:45 2021 +0200
Related: tdf#141633 allow "small-button" elements to shrink further
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123136

Caolán, could these button move back further to the left so the scrollbar doesn't interfere?
Comment 4 Telesto 2024-01-20 22:20:47 UTC
*** Bug 159298 has been marked as a duplicate of this bug. ***
Comment 5 Stéphane Guillou (stragu) 2024-02-01 03:43:23 UTC
*** Bug 155980 has been marked as a duplicate of this bug. ***
Comment 6 Stéphane Guillou (stragu) 2024-02-01 03:44:41 UTC
*** Bug 150656 has been marked as a duplicate of this bug. ***
Comment 7 Stéphane Guillou (stragu) 2024-02-01 03:46:10 UTC
*** Bug 159480 has been marked as a duplicate of this bug. ***
Comment 8 Caolán McNamara 2024-02-19 10:41:35 UTC
There's no perfect solution from our side that I can really see. The overlay scrollbars are just how gtk works by default. We can turn them off here and there, or even globally, but that's not great either from an integration into the desktop perspective. As far as I can see there also isn't a (or at least, not discoverable) way to dismiss an overlay scrollbar. I feel like the best I can think of would be on the gtk side to do something like auto-dismiss the overlay scrollbar after the tooltip hover timeout if the pointer remains the part of the scrollbar that is over another focusable widget.

But for this specific case of the "more options" control lets try Stéphane's suggestion of moving that control leftwards about 9 pixels to get it out of the typical hot-zone for the overlay scrollbar.

https://gerrit.libreoffice.org/c/core/+/163586
Comment 9 Commit Notification 2024-02-19 12:39:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/81adba0eeed883b939477259ac53c04459d25a4c

tdf#155961 put some spacing to the right of the "more options" toolbar

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Caolán McNamara 2024-02-19 12:39:54 UTC
done that on master, backport to 24.2 in gerrit
Comment 11 Commit Notification 2024-02-20 09:29:30 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/7f27c90c12fbfc779771dc32362a60160bd99386

tdf#155961 put some spacing to the right of the "more options" toolbar

It will be available in 24.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2024-03-05 17:35:09 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/1434802f097030ce13823aa44034b51106e75af2

tdf#155961 put some spacing to the right of the "more options" toolbar

It will be available in 7.6.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Stéphane Guillou (stragu) 2024-03-06 05:39:54 UTC
Thanks Caolán, your fix works well for me on Ubuntu 22.04 + GNOME 42.9 and:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9574a62add8e4901405e12117e75c86c2d2c2f21
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded