Bug 156047 - In Impress template, copied title box takes formatting of the title of the slide it is pasted into
Summary: In Impress template, copied title box takes formatting of the title of the sl...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: x86-64 (AMD64) All
: low minor
Assignee: Laurent Balland
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: Templates
  Show dependency treegraph
 
Reported: 2023-06-25 02:37 UTC by d00m3d.olw
Modified: 2024-09-20 07:15 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Proposed new Blue_Curve template with modified font colors (12.69 KB, application/vnd.oasis.opendocument.presentation-template)
2024-09-14 09:53 UTC, Laurent Balland
Details
Proposed new Vivid template with modified font colors (13.49 KB, application/vnd.oasis.opendocument.presentation-template)
2024-09-14 09:55 UTC, Laurent Balland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description d00m3d.olw 2023-06-25 02:37:28 UTC
Using the Blue Curve template in Impress, the text in copied Title box is invisible because its colour attribute (default in red) is lost, or changed to white, for unknown reason.

Steps to Reproduce:
1. Start a new Impress Presentation
2. In "Select a Template" dialog box, choose "Blue Curve"
3. On page 1, type anything, e.g. 'Test!!!' in "Click to add Title" box
4. Copy this title box to page 2.

Expected result:
Title box with 'Test!!!' text should appear on page 2, same appearance as first page.

Actual result:
Title box is copied but text is not visible because text is same (white) colour
as background.  'Test!!!' text can be visible again when its colour is changed.

Version of LO that is LKG:
====================================================
Version: 5.0.6.3 (x64)
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: en-HK (en_HK)

Affected versions (most likely from 6.0 onwards)
====================================================
Version: 6.0.7.3 (x64)
Build ID: dc89aa7a9eabfd848af146d5086077aeed2ae4a5
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-HK (en_HK); Calc: CL

Version: 6.4.8.0.0+ (x64)
Build ID: 188ddcd482150b5fdeb44d97e57831e3e27b3f5b
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: GL; VCL: win; 
Locale: en-US (en_HK); UI-Language: en-US
Calc: CL

Version: 7.4.8.0.0+ (x64) / LibreOffice Community
Build ID: 01ce3266484451e0984ed1ba07944745f44fc9e0
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_HK); UI: en-US
Calc: CL

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 20873f073ae4a9478f0a84355f779a2176bd2ec8
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_HK); UI: en-US
Calc: CL threaded

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c968d8989004301b49d67a093a6eb8a629533837
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_HK); UI: en-US
Calc: CL threaded

This bug is likely inherited from 6.0.x, and it is still present in the latest master branch.

I think this bug should not be difficult to correct.  I would be highly appreciated if it may be fixed as soon as possible.

Thanks a lot!
Comment 1 Stéphane Guillou (stragu) 2023-06-29 00:16:11 UTC
Also happens in the Vivid template, copying the title text box from the first slide to the second. But it doesn't if pasting into the third slide.

My understanding is that it depends on what default style each slide of the template assigns to the title boxes:
- For Vivid, the title is blue for the first slide but white (on blue) for the second
- For Blue Curve, the title is red for the first slide but white (one blue) for the second

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 609a1567d0e60ca11800df56059b97b6a61ad117
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Using the exported Blue Curve template, I could reproduce in OOo 3.3, so this is inherited.

Once the text colour is changed, the formatting is persistent when pasted.
Comment 2 d00m3d.olw 2024-09-13 02:21:40 UTC
I am quite disappointed that when a newer templates for Blue Curve and Vivid are released but my reported bugs still present. :(

https://bugs.documentfoundation.org/show_bug.cgi?id=162490
Comment 3 Laurent Balland 2024-09-14 09:25:00 UTC
I understand that may be frustrating, but from my point of view, it works as expected: when pasting a text, the copied text is formatted with the style of the destination slide.
It is the same behavior in other modules like Writer: if you copy a text with a style which already exists in the destination document, text will change its format to respect the style of the destination document.
In Impress, the difference is that each master has its own styles for title, subtitle, outline, etc.
In your example, on slide2, you cannot expect that both titles (empty placeholder and copied text) have a different format. In this case, you need to modify either the style format in master, or the format of the copied text.

What I can propose to avoid such frustration, is to set a light grey font color for the title on second page. Then, when pasting a title in the blank part of the slide, it would still be visible.
Comment 4 Laurent Balland 2024-09-14 09:53:19 UTC
Created attachment 196436 [details]
Proposed new Blue_Curve template with modified font colors

Font color for title on second slide is now light grey
Comment 5 Laurent Balland 2024-09-14 09:55:20 UTC
Created attachment 196437 [details]
Proposed new Vivid template with modified font colors

Font colors of title and text were modified on second slide to follow opposite colors of first slide
Comment 6 d00m3d.olw 2024-09-20 04:13:01 UTC
Dear Laurent

Many thanks for following up on this subject.

I thought this was implemented in the master brand but upon tested the latest snapshot dated as of today, it wasn't.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cb08fb797c58a4d21e7ae3a700b0e9ed30524a90
CPU threads: 16; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL threaded

I managed to discover that you are proposing changes on Blue Curve and Vivid templates, as .otp attachments in this bug report.  I have tested both templates.

I can understand your view point as paragraph or page style may have different formats.  For me, as a user, I am more concerned whether the copied text should be same as original.  However, I am pleased with your proposed changed because, at least, copied text are now visible, which hints the user should make changes. This can be an acceptable compromise if you insist on your view point.

I meant, I have no objections if you proceed to implement such changes and then close this bug report.
Comment 7 Laurent Balland 2024-09-20 07:11:41 UTC
(In reply to d00m3d.olw from comment #6)
> Dear Laurent
> 
> Many thanks for following up on this subject.
> 
> I thought this was implemented in the master brand but upon tested the
> latest snapshot dated as of today, it wasn't.
> 
> Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: cb08fb797c58a4d21e7ae3a700b0e9ed30524a90
> CPU threads: 16; OS: Windows 10 X86_64 (10.0 build 19045); UI render:
> Skia/Vulkan; VCL: win
> Locale: en-HK (en_HK); UI: en-US
> Calc: CL threaded
> 
> I managed to discover that you are proposing changes on Blue Curve and Vivid
> templates, as .otp attachments in this bug report.  I have tested both
> templates.
> 
> I can understand your view point as paragraph or page style may have
> different formats.  For me, as a user, I am more concerned whether the
> copied text should be same as original.  However, I am pleased with your
> proposed changed because, at least, copied text are now visible, which hints
> the user should make changes. This can be an acceptable compromise if you
> insist on your view point.
> 
> I meant, I have no objections if you proceed to implement such changes and
> then close this bug report.

Thank you so much for your detailed feedback. Actually, I was expecting some feedback before pushing my changes. That's why you cannot find it yet in master. An automatic message will appear in this bug report as soon as the patch will be part of master.
Have a good day.
Comment 8 Commit Notification 2024-09-20 07:12:54 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8722639f3a270e2903810b85ef40a68cb0a14646

tdf#156047 Avoid white title on Vivid and BlueCurve

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.