Bug 156262 - Duplicated "I" accelerator in Insert >Table of Content and Index
Summary: Duplicated "I" accelerator in Insert >Table of Content and Index
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: low minor
Assignee: Stéphane Guillou (stragu)
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Shortcuts-Accelerators
  Show dependency treegraph
 
Reported: 2023-07-12 20:45 UTC by TorrAB
Modified: 2024-04-30 13:12 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TorrAB 2023-07-12 20:45:01 UTC
Description:
In Writer, Insert>Index leads to a submenu with 3 items, two of which have identical shortcuts, I. Actually, the first one is unneeded (User can just hit Enter.), and confusing, and barely visible in darkMode. A colored (green?) background highlight would be better.


Steps to Reproduce:
1.open Insert>Index
2.alt-x
3.

Actual Results:
2 duplicate shortcuts, I;
highlight is barely visible in darkMode.

Expected Results:
Nice and clear highlight


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 4; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-CA (en_CA); UI: en-US
Calc: CL threaded
Comment 1 Stéphane Guillou (stragu) 2023-07-13 11:49:58 UTC
Let's focus on the accelerator shortcuts, as we need to have one issue per bug report. (Can you please open a separate bug report about the dark mode issue, with a screenshot of it?)

The shared "I" accelerator started in LO 4.4.0.0 when "Entry" was renamed to "Index Entry".

Users can cycle through accelerators by pressing them again, but in this case, there's not that many items in the submenu so I think we can use a different one.

Reproduced in a recent master build too:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 77fca616e0bd79e0b405fd0b3543cf8e94e15df3
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 Stéphane Guillou (stragu) 2023-07-23 17:19:18 UTC
Proposed fix in gerrit: https://gerrit.libreoffice.org/c/core/+/154438
Comment 3 Commit Notification 2023-07-24 06:15:13 UTC
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a407562a293d2cc5c7755951948a4e1e168d92bf

tdf#156262: use default ToC accelerator to avoid duplicate

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.