Bug 156310 - Cross reference does not jump to number range
Summary: Cross reference does not jump to number range
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Fields-Cross-Reference
  Show dependency treegraph
 
Reported: 2023-07-16 14:44 UTC by sdc.blanco
Modified: 2023-12-09 20:00 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2023-07-16 14:44:35 UTC
1.  Open new document.
2. Insert Frame and then Caption  (I used "Text" for category name).
3. Click in document canvas and insert cross reference to the caption.
   (i.e., Ctrl+F2, Cross-references tab, 
   Type: "Text", Selection: "Text 1..."  Refer using: "Category and Number"
   Insert)
4. Click on inserted cross-reference.

Actual:  Nothing happens
Expected: Move cursor to Caption in the frame.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 693411e60c6bbd1c2ef25490cc3902f6b2461682
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL threaded


Additional information:

Double-click on cross-reference opens "Edit Fields".
Comment 1 sdc.blanco 2023-07-17 12:05:05 UTC
Additional information.

1.  Ctrl-click on inserted cross-reference will jump to caption.

2.  Works as expected in 7.2.7.2 (i.e., click on cross-reference jumps to caption in frame), but....
    ...if frame with caption is cut and pasted back in the document, then
       a. click on cross-reference has no effect
       b. double-click opens edit field for cross-reference
       c. ctrl-click has no effect.

       (may be related to bug bug 145372)
Comment 2 Dieter 2023-08-01 07:59:22 UTC
I confirm it with

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 42f0422d19c4d0a2fb09654fb6d1d92e50f6dd5c
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Simple click highlights frame (but focus in navigator is still on cross reference); don't see the usecase of this behaviour
Ctrl+click works as expected

Not sure, if there has been an intended change in behaviour. So I'm not sure, if it is a bug or not.
Comment 3 sdc.blanco 2023-08-01 11:09:24 UTC
(In reply to Dieter from comment #2)
> Not sure, if there has been an intended change in behaviour. So I'm not
> sure, if it is a bug or not.
So let's ask UXEval...
Comment 4 Heiko Tietze 2023-08-18 10:32:54 UTC
With v7.4 (and below) it was not possible to click on a field, eg to select it, while now you can do. Both, single click and ctrl+click navigated to the reference while now only ctrl+click does. Sounds good to me, but I cannot find the ticket. Maybe bug 123626, Samuel/Miklos (found it by searching Gerrit for ctrl+click)?
Comment 5 Miklos Vajna 2023-08-18 14:33:21 UTC
Hm, I don't recall an intentional change from me here. But we could bibisect it. :-)
Comment 6 Stéphane Guillou (stragu) 2023-08-30 16:36:57 UTC
The behaviour started in 7.6.
Bibisected with linux-64-7.6 repo to 76f6e5fa94ffa7b7b06acef23ab27d3857da8795 which points to core commit:

commit 7b99871635cd48c2a8a1d0afbd7afc60a45cc2ff
author	Vojtěch Doležal Mon Feb 27 08:52:35 2023 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	Tue Mar 07 07:12:31 2023 +0000
tdf#153396 - Bibliography marks improvements
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147868

Marking as a regression, as I assume it was unintended.
Vojtěch, can you please have a look?
Comment 7 dolezvo1 2023-08-30 16:54:51 UTC
Hi, it really does seem like it. I think I was doing something which also related to something which worked with Ctrl+Click.

If I were to guess which lines relate to this, I would say it's in sw/source/uibase/wrtsh/wrtsh2.cxx, the added break for case SwFieldIds::GetRef.
Comment 8 sdc.blanco 2023-08-30 19:08:15 UTC
Have re-tested, without a frame. Just insert a number range variable and then a cross-reference to that variable.  

As expected:  Ctrl-click on cross-reference variable jumps to the number-range variable.

Unexpected:  single-click does not jump  (but it should). 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 218a7650a5cf03f895bed19c68d6f02daec536e9
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL threaded

Updating bug summary...
Comment 9 dolezvo1 2023-12-09 11:10:19 UTC
I just tried it out and I can see the behaviour is really confusing as it is. However, the added functionality of being able to select the reference is actually nice, imo. Would it be a valid solution to show a hint that you should use Ctrl+Click to jump to the target, like it happens with similar elements?
Comment 10 sdc.blanco 2023-12-09 12:36:49 UTC
(In reply to dolezvo1 from comment #9)
> However, the added functionality of being able to select the reference
> is actually nice, imo. 
Please explain.  It is possible to select the reference in 7.2, and also use single-click, so what is the "added functionality"?

> Would it be a valid solution to show a hint that you
> should use Ctrl+Click to jump to the target, like it happens with similar
> elements?
Only if single-click functionality is rejected.  Note that single-click works for other cross-reference types, so I think there must be a good reason/argument for not having the same single-click functionality for the number range type.
Comment 11 dolezvo1 2023-12-09 20:00:21 UTC
(In reply to sdc.blanco from comment #10)
> Please explain.  It is possible to select the reference in 7.2, and also use
> single-click, so what is the "added functionality"?

Wasn't it only possible using keyboard? I don't think right click used to select it, but I might be misremembering. I do remember for certain that I jumped away more than once accidentally when trying to select it, though.

> Only if single-click functionality is rejected.  Note that single-click
> works for other cross-reference types, so I think there must be a good
> reason/argument for not having the same single-click functionality for the
> number range type.

I admit don't know a lot about the other cross reference types, but for what it's worth, hyperlinks and bibliographical references do use Ctrl+Click, so I think there is a case to be made for unification of the command.