Bug 156334 - Switching to another slide should hide the Table toolbar
Summary: Switching to another slide should hide the Table toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0 target:24.8.0.0.beta2
Keywords:
Depends on:
Blocks: ImpressDraw-Tables Impress-UX
  Show dependency treegraph
 
Reported: 2023-07-17 14:13 UTC by Rafael Lima
Modified: 2024-11-01 13:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Video showing the problem (225.82 KB, video/mp4)
2023-07-17 14:13 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-07-17 14:13:52 UTC
Created attachment 188413 [details]
Video showing the problem

In Impress, when you're editing a table and then switch to a different slide, the Table toolbar should be hidden as soon as the new slide is shown, since there's no target for the operations in the toolbar (see attached video for more info).

Steps to reproduce (similar to the video)
1) Create a presentation with 2 or more slides
2) Insert a table in Slide 1 and start editing the table (the text cursor must be shown; if only the outer table object is selected, then the problem does not happen)
3) Now click some other slide in the Slide pane (f.i. Slide 2)
4) Notice that the Table toolbar is still visible, although no table is selected
5) The table toolbar only disappears if you click an empty area in the current slide

Expected behavior: The table toolbar should disappear as soon as another slide is selected.

System info:

Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.5.4-0ubuntu0.23.04.1
Calc: threaded

Also in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a4af5432753408c4eea8a8d56c2f48202160c5fe
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 Stéphane Guillou (stragu) 2023-08-02 22:04:27 UTC
Reproduced in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 47ca3f1f762352b488d58b3bf23d5776576f1cca
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same in OOo 3.3, so inherited.
Same in Draw.
Comment 2 Aaron 2023-08-08 23:36:48 UTC
Thank you for reporting the bug. I can not reproduce the bug in

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: threaded
Comment 3 Stéphane Guillou (stragu) 2023-08-09 11:32:57 UTC
I can reproduce in 7.5.5.2 on Linux.
Aaron, are you sure you had the cursor inside the table before switching slides?
Comment 4 Aaron 2023-08-09 23:01:54 UTC
(In reply to Stéphane Guillou (stragu) from comment #3)
> I can reproduce in 7.5.5.2 on Linux.
> Aaron, are you sure you had the cursor inside the table before switching
> slides?

Yes I'm sure. I clicked in the table, wrote some text then switched to the next slide and the toolbar on the right with properties and table design heading disappears and gets replaced with layouts. Is that the steps to reproduce? Because the video from the attachment 188413 [details] is not working for me. I can't seem to play the video.
Comment 5 Stéphane Guillou (stragu) 2024-11-01 13:26:18 UTC
(In reply to Aaron from comment #4)
> [...]the toolbar on the right with properties and table design
> heading disappears and gets replaced with layouts.
The toolbar in question is the one at the bottom of the window, not in the sidebar.

However, I don't reproduce in my own build anymore:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6bd9f1f93301756bdc6fa57911d163e9fa5ad313
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Nor in:

Version: 24.8.2.1 (X86_64) / LibreOffice Community
Build ID: 0f794b6e29741098670a3b95d60478a65d05ef13
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Bibisected the fix with linux-64-24.8 repo to first good build [b85b77beb47f569a4ac2477d11e5f69ab5f9922c] which is 002f4214084718a98fca6799133150f6b37e00f0, cherrypicked from:

commit 5e143492320dac8cdf8b2956799ca366f3d8e72c
author	Sarper Akdemir 	Fri Jun 07 21:14:44 2024 +0200
committer	Sarper Akdemir 	Fri Jun 28 14:25:36 2024 +0200
tdf#33603: fix notespane (side/tool)bar interactions
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169658

Thanks Sarper! :)