Bug 156372 - The height of the header is larger when compared to MSO
Summary: The height of the header is larger when compared to MSO
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0 all versions
Hardware: All All
: medium normal
Assignee: SATYA SRINIVAS K
URL:
Whiteboard: target:24.2.0 target:7.6.1 target:7.5.6
Keywords: bibisected, bisected, filter:doc, filter:docx, regression
Depends on:
Blocks: DOCX-Header-Footer
  Show dependency treegraph
 
Reported: 2023-07-19 05:38 UTC by SATYA SRINIVAS K
Modified: 2023-07-31 18:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Simple Doc to reproduce (32.00 KB, application/msword)
2023-07-19 05:39 UTC, SATYA SRINIVAS K
Details
last Para moved to next page (91.34 KB, image/png)
2023-07-19 05:39 UTC, SATYA SRINIVAS K
Details
Header Size comparision (32.00 KB, application/msword)
2023-07-19 05:39 UTC, SATYA SRINIVAS K
Details

Note You need to log in before you can comment on or make changes to this bug.
Description SATYA SRINIVAS K 2023-07-19 05:38:36 UTC
Description:
The content from the first page is moving to the next page due to the large header height.

Steps to Reproduce:
1.Open the attached "Header_Size_Simple.doc" in both LO and MS word.
2.Observe that the last paragraph on the first page is moved to the next page.
3.Observe that the size of the header in both MSO and LO.


Actual Results:
The content from first page is moved to next page due to the header size.

Expected Results:
LO should render same as MS word.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Attachments:"Header_Size_Simple.doc","Header_Size_Issue.png" and "Para_moved_Issue.png"
Comment 1 SATYA SRINIVAS K 2023-07-19 05:39:05 UTC
Created attachment 188461 [details]
Simple Doc to reproduce
Comment 2 SATYA SRINIVAS K 2023-07-19 05:39:29 UTC
Created attachment 188462 [details]
last Para moved to next page
Comment 3 SATYA SRINIVAS K 2023-07-19 05:39:47 UTC
Created attachment 188463 [details]
Header Size comparision
Comment 4 Justin L 2023-07-19 13:52:36 UTC
Broken in LO 7.0 with commit fbd62e247fd588a595e44cec787fc8944f158777
Author: Samuel Mehrbrodt on Wed May 20 08:41:46 2020 +0200
    tdf#128195 Keep spacing below last paragraph in header (docx)
Comment 5 Justin L 2023-07-19 13:55:40 UTC
The table was being treated as a "last element" in the header, even though it is followed by a paragraph. The lower spacing was being doubled for every cell in the table.
A table cannot be the last "thing" in an MSO header - it is always followed by a paragraph.
Comment 6 Commit Notification 2023-07-19 19:30:26 UTC
Satya committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a3b76c2cb216a55d60fdf8b4533ac02c7f37c005

tdf#156372 sw: Stop adding GetLower to every cell in header table

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-07-31 13:50:41 UTC
Satya committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/a3d2630901608a0816bfbc490f695dde7c962952

tdf#156372 sw: Stop adding GetLower to every cell in header table

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-07-31 18:05:15 UTC
Satya committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/9c5c63d567be3623d609feda47026631cb48263b

tdf#156372 sw: Stop adding GetLower to every cell in header table

It will be available in 7.5.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.