Bug 156649 - FILEOPEN PPTX: images shows too dark/strong (transparency?)
Summary: FILEOPEN PPTX: images shows too dark/strong (transparency?)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0 all versions
Hardware: All All
: medium normal
Assignee: Sarper Akdemir (allotropia)
URL:
Whiteboard: target:24.2.0 target:7.6.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: PPTX-Images
  Show dependency treegraph
 
Reported: 2023-08-07 07:50 UTC by Gerald Pfeifer
Modified: 2023-09-09 22:33 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample slide (PPTX) (5.02 MB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2023-08-07 07:50 UTC, Gerald Pfeifer
Details
Screenshot with Impress (1.06 MB, image/png)
2023-08-07 07:50 UTC, Gerald Pfeifer
Details
Screenshot with PowerPoint (694.62 KB, image/png)
2023-08-07 07:50 UTC, Gerald Pfeifer
Details
The example file in PP 2016 and Impress 7.0 (408.44 KB, image/png)
2023-08-09 11:45 UTC, Gabor Kelemen (allotropia)
Details
The example file in PP 2016 and Impress master (494.92 KB, image/png)
2023-08-09 11:52 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2023-08-07 07:50:07 UTC
Created attachment 188820 [details]
Sample slide (PPTX)

1. Open sample document in Impress and PowerPoint
2. Observe how the colors on the left half of the slide appear much
   stronger/darker in Impress.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 47ca3f1f762352b488d58b3bf23d5776576f1cca
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US

and back to 7.0.  6.4 has the color right, alas the shape wrong.


If I had to guess I'd say this is a regression introduced (or incomplete
implementation) related to bug #140714

  "FILEOPEN PPTX: image styles that clip images into curvy shapes 
  missing (and images shown rectangular)"
Comment 1 Gerald Pfeifer 2023-08-07 07:50:35 UTC
Created attachment 188821 [details]
Screenshot with Impress
Comment 2 Gerald Pfeifer 2023-08-07 07:50:58 UTC
Created attachment 188822 [details]
Screenshot with PowerPoint
Comment 3 Gabor Kelemen (allotropia) 2023-08-09 11:34:37 UTC
Indeed, bibisected under win-7.1 to

https://git.libreoffice.org/core/+/ff751d42a4f672e25188ba90958e91d7869f395a%5E%21

tdf#140714 Import graphics cropped into custom geometry as custom shapes.
Comment 4 Gabor Kelemen (allotropia) 2023-08-09 11:45:48 UTC
Created attachment 188868 [details]
The example file in PP 2016 and Impress 7.0

In PP there is a Sharpness type image correction set to 100% and a Contrast to -9 percent.
When the shape was imported as image, this(?) resulted in a 55% transparency setting and (despite the sidebar is having brightness/contrast settings, similar to PP - this -9% was not imported as such) the visual appearance was ~okay.
Comment 5 Gabor Kelemen (allotropia) 2023-08-09 11:52:18 UTC
Created attachment 188869 [details]
The example file in PP 2016 and Impress master

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c3cf88f73e29a79f890782b31d1ecc6ed1c376ea
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Now it's imported as a bitmap filled shape, but there are no correction settings in the UI for the bitmap filling the shape. Some settings may be statically applied to the image at import time, but probably not everything used here.
Comment 6 Commit Notification 2023-09-08 06:58:21 UTC
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b0e8ce9967acf3a759e5b85c4a0d16d7dad275fe

tdf#156649: oox: correct import alphaModFix for custom shapes

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-09-08 10:54:52 UTC
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/7a0b8513d76e12154fe85744b9acc03c369b42c6

tdf#156649: oox: correct import alphaModFix for custom shapes

It will be available in 7.6.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Gerald Pfeifer 2023-09-09 22:33:16 UTC
Happy to confirm/verify this with

  Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: 10689e0f24e96781664e734fe23d109af6df77f1
  CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

Thank you, Sarper!