Bug 156651 - UI: zh_TW word "column"(欄) in sort window is partly blocked by accelerator (same issue in Japanese)
Summary: UI: zh_TW word "column"(欄) in sort window is partly blocked by accelerator (s...
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
Depends on:
Blocks: Shortcuts-Accelerators Sorting
  Show dependency treegraph
 
Reported: 2023-08-07 08:00 UTC by JackHsu
Modified: 2024-08-21 03:16 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Black circles indicate the partly blocked words of "column" in zh_tw (20.87 KB, image/png)
2023-08-07 08:00 UTC, JackHsu
Details
screenshot of sort dialog in LO 7.5.7.1 (left) and a recent trunk build at 24.2 (right) (140.85 KB, image/png)
2023-10-17 08:30 UTC, Stéphane Guillou (stragu)
Details
LibO762UI-enUS-Japanese (62.22 KB, image/png)
2023-10-30 02:16 UTC, Saburo
Details
Screenshot (61.95 KB, image/png)
2024-01-03 14:37 UTC, Heiko Tietze
Details
CharactorImage (77.83 KB, image/png)
2024-01-22 11:29 UTC, Saburo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description JackHsu 2023-08-07 08:00:38 UTC
Created attachment 188823 [details]
Black circles indicate the partly blocked words of "column" in zh_tw

The zh_tw word "column"(欄) in sort window is partly blocked (as attached picture) but the word "column" in en_US is shown correctly.
Comment 1 Stéphane Guillou (stragu) 2023-10-17 08:30:22 UTC
I don't get accelerators / mnemonics next to those words in a current trunk build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e9374f74385d7dfe77d1902d3d82af20143bc775
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: zh-TW
Calc: threaded

Nor in 7.5.7.1:

Version: 7.5.7.1 (X86_64) / LibreOffice Community
Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: zh-TW
Calc: threaded

Do you still reproduce in safe mode? Can you please test in the latest versions of LibreOffice?

Thank you!
Comment 2 Stéphane Guillou (stragu) 2023-10-17 08:30:51 UTC
Created attachment 190249 [details]
screenshot of sort dialog in LO 7.5.7.1 (left) and a recent trunk build at 24.2 (right)
Comment 3 Saburo 2023-10-30 02:16:01 UTC
Created attachment 190503 [details]
LibO762UI-enUS-Japanese

The same thing is reproduced in Japanese

Like the English UI It would be better if the label was wide and the combo box was narrow.
Comment 4 Saburo 2023-10-31 05:13:50 UTC
Guidelines don't seem to be followed

https://wiki.documentfoundation.org/Design/Guidelines/PropertyDialog
Text
Always left-align labels. Phrase the text so captions have similar length.
Comment 5 Saburo 2023-12-24 08:29:55 UTC
Reproduce with LibO24.8 on Windows

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 297a6673175308168669870882c016b496652a76
CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: CL threaded

Does not reproduce on ubuntu but reproduces on kubuntu
Comment 6 Stéphane Guillou (stragu) 2023-12-27 10:16:57 UTC
Thank you both, reproduced with kf5 VCL plugin and zh-TW UI, in which accelerators are shown by default.

Started in 7.4, I assume when such labels were added for bug 140290.

Repro in:

Version: 7.4.7.2 / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: zh-TW
Calc: threaded

No repro in:

Version: 7.3.7.2 / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: zh-TW
Calc: threaded

Heiko and Eike, can you please have a look?
Comment 7 Eike Rathke 2024-01-03 12:21:08 UTC
No time for this, please find someone else.
Heiko implemented the change.
Comment 8 Heiko Tietze 2024-01-03 14:37:53 UTC
Created attachment 191730 [details]
Screenshot

I'm on Arch Linux, KDE, installed noto-fonts-sc (Noto Sans CJK SC) for the test. Looks good to me and I wonder if you spot an issue with the font and missing space on the right.

If not, the sort key dialog sc/uiconfig/scalc/ui/sortkey.ui has a dynamical label depending on whether you sort by column or row. The accelerator is assigned dynamically. 

If this wont help we could change the horizontal alignment from 1.0 (should be right for LTR and left for RTL) to none. 

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b72aa31d7db38c81f757206e4e51844b839797ea
CPU threads: 32; OS: Linux 6.6; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (en_US.UTF-8); UI: zh-TW
Calc: threaded
Comment 9 Saburo 2024-01-22 11:29:51 UTC
Created attachment 192096 [details]
CharactorImage

Characters are still not fully displayed
Comment 10 QA Administrators 2024-07-21 03:14:26 UTC Comment hidden (obsolete)
Comment 11 QA Administrators 2024-08-21 03:16:08 UTC
Dear JackHsu,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp