Bug 156682 - Floating table "loops" back to top of the cell, hangs when continuing inserting paragraphs
Summary: Floating table "loops" back to top of the cell, hangs when continuing inserti...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.1 rc
Hardware: All All
: medium major
Assignee: Miklos Vajna
URL:
Whiteboard: target:24.2.0 target:7.6.1
Keywords:
Depends on:
Blocks: DOCX-Floatingtable
  Show dependency treegraph
 
Reported: 2023-08-08 20:42 UTC by Stéphane Guillou (stragu)
Modified: 2023-08-30 10:08 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-08-08 20:42:24 UTC
Following up from bug 156349:

1. Open attachment attachment 188431 [details]
2. Place cursor at the end of cell B1
3. Press enter many times

Results:
- Row 8 spills to second page, OK
- Once row 7 is supposed to split over the two pages, the second part disappears
- Once cursor reaches the bottom of the page, it then "loops" back to the top of the cell
- Press enter once more when it reaches below "Eins": cursor disappears, LibreOffice hangs.

Repro in recent master build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 42364fbfafaa95773c073cc080142b64ec1786fb
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

As well as 7.6.0.2.

No repro in 7.5.5.2 (cell would continue spilling below the page indefinitely, in the background) but won't mark as a regression given that floating table support is new.

Miklos, can you please have a look?
Comment 1 Miklos Vajna 2023-08-09 07:13:48 UTC
Yes, if I press enter at the end of B1 5 times, then the first 4 is ~OK, but the 5th one stops the blinking cursor, probably the layout loops. I'll see what can I do.
Comment 2 Commit Notification 2023-08-16 08:44:37 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1cf29168840f84c2e946e2678b99988e83503c96

tdf#156682 sw floattable: fix missing del of master anchor para por on split

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Miklos Vajna 2023-08-16 08:46:18 UTC
The first problem was that the "He heard" text was duplicated on page 1 & page 2 after pressing "enter" at the end of B1 two times. Once I fixed that, the original (second) problem also disappeared for me. So the above if meant to fix the reported bug.
Comment 4 Commit Notification 2023-08-22 19:00:30 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/2dc53489d6c36a5a04c154d78a9e8ea928407328

tdf#156682 sw floattable: fix missing del of master anchor para por on split

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Stéphane Guillou (stragu) 2023-08-29 15:57:48 UTC
Thanks Miklos, much improved now.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 16d43b7c5396d6382926d514dc9ce10b3ce94cba
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No more disappearing halves, no "jump to top", no hang.

However, still some odd behaviour when continuing pressing Enter once on the second page (cursor looks like it jumps to the next cell and cell looks split in two, instead of extending the active cell; adding text overlaps other text until refreshed...)
I can open a new report with a clearer description, if you prefer.
Comment 6 Miklos Vajna 2023-08-30 06:58:41 UTC
Yes, please do that. Thanks! :-)
Comment 7 Stéphane Guillou (stragu) 2023-08-30 10:08:26 UTC
(In reply to Miklos Vajna from comment #6)
> Yes, please do that. Thanks! :-)

Done in bug 157005. Thanks! :)