Bug 156718 - FILEOPEN PPTX: alternating colored lines in table / style don't render properly
Summary: FILEOPEN PPTX: alternating colored lines in table / style don't render properly
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Tibor Nagy
URL:
Whiteboard: target:24.8.0 target:24.2.1 target:7.6.5
Keywords: bibisected, bisected, filter:pptx, implementationError
Depends on:
Blocks: PPTX-Tables
  Show dependency treegraph
 
Reported: 2023-08-10 13:54 UTC by Gerald Pfeifer
Modified: 2024-01-29 09:12 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample slide (PPTX) (49.31 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2023-08-10 13:54 UTC, Gerald Pfeifer
Details
Visual comparison Impress (left) vs PowerPoint (right) (43.67 KB, image/png)
2023-08-10 13:54 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2023-08-10 13:54:08 UTC
Created attachment 188911 [details]
Sample slide (PPTX)

Compare the rendering of the sample document between Impress and
PowerPoint and notice how

 - alternating lines are not fully colored blue, just the medium
   column is;
 - table headings render blue instead of black;
 - extra horiztonal lines appear at the top and bottom.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 47ca3f1f762352b488d58b3bf23d5776576f1cca
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Comment 1 Gerald Pfeifer 2023-08-10 13:54:33 UTC
Created attachment 188912 [details]
Visual comparison Impress (left) vs PowerPoint (right)
Comment 2 Xisco Faulí 2023-08-10 14:41:38 UTC
Reproduced in

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0d571ff8079f858a5650bf6cbb38296d22cc58e1
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 3 Xisco Faulí 2023-08-10 14:42:57 UTC
and in

Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: 229123ccc6f90ebf66b3e659bebbd53f8a9bdd3a
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 4 Gabor Kelemen (allotropia) 2023-08-13 21:33:01 UTC
This seems to have started in 6.4 when import of table styles was implemented in:

https://git.libreoffice.org/core/+/2c3f7d4ee0a0b2bf6efc41670645bd361f1b76ef

author	Gülşah Köse <gulsah.kose@collabora.com>	Fri Dec 27 21:06:08 2019 +0300
committer	Andras Timar <andras.timar@collabora.com>	Tue Jan 07 14:49:50 2020 +0100

tdf#107604 Handle predefined table styles.
Comment 5 Commit Notification 2024-01-22 12:35:17 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/27a1eccae1763b8efa17c909820f57f84361d308

tdf#156718 PPTX import: fix the different formatting in table style

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2024-01-23 08:26:40 UTC
Verified in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d71c21890c908225945f0fc3566255ed150f660
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Tibor, thanks for fixing this issue!!
Comment 7 Commit Notification 2024-01-23 08:38:07 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/67ae17ad8a74620eb744976d56f8d763893e847c

tdf#156718 PPTX import: fix the different formatting in table style

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Gabor Kelemen (allotropia) 2024-01-23 21:33:02 UTC
(In reply to Gerald Pfeifer from comment #0)
> Compare the rendering of the sample document between Impress and
> PowerPoint and notice how
> 
>  - alternating lines are not fully colored blue, just the medium
>    column is;
>  - table headings render blue instead of black;
These seem to be fixed now.

>  - extra horiztonal lines appear at the top and bottom.
This part lives on as bug 159346
Comment 9 Commit Notification 2024-01-29 09:12:36 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/00dd94eda1e4b46c7f9a53750aa829c31c6830d3

tdf#156718 PPTX import: fix the different formatting in table style

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.