Bug 156800 - No way to change selection colour in Libo on 7.6.0 release ?
Summary: No way to change selection colour in Libo on 7.6.0 release ?
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.2 rc
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Cell-Selection
  Show dependency treegraph
 
Reported: 2023-08-17 14:44 UTC by nouvo09
Modified: 2023-09-15 10:00 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
example (3.67 KB, image/png)
2023-08-17 14:50 UTC, nouvo09
Details
launching Calc 7.5.5 (146.84 KB, image/png)
2023-08-18 10:29 UTC, nouvo09
Details
launching Calc 7.6.0.3 (144.97 KB, image/png)
2023-08-18 10:30 UTC, nouvo09
Details
7.5 (top) vs 7.6 (bottom) (41.39 KB, image/png)
2023-09-01 09:03 UTC, Stéphane Guillou (stragu)
Details
Screencast accent colors on Ubuntu (1.06 MB, image/gif)
2023-09-05 07:24 UTC, Heiko Tietze
Details
VCL=gen on Ubuntu (45.83 KB, image/png)
2023-09-05 08:21 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nouvo09 2023-08-17 14:44:57 UTC
Description:
Till 7.5 release, the colour of the highlighted/selected colomn, line , and cell was blue .

On the last 7.6.0.x release (not beta or RC) , it became braun. I didn't find anything in the help. Nobody knows. So is there a way to change that feature ?
Thanks

Steps to Reproduce:
1.Open Calc
2.Select a cell
3.Just look at the colour.

Actual Results:
Highlighted in braun

Expected Results:
Highlighted in blue


Reproducible: Always


User Profile Reset: Yes

Additional Info:
No other precision needed
Comment 1 nouvo09 2023-08-17 14:50:19 UTC
Created attachment 189008 [details]
example
Comment 2 raal 2023-08-17 15:25:23 UTC
On my PC (Linux, Gnome) it depends on the desktop enviroment's appearence. Try to change it.
Comment 3 nouvo09 2023-08-17 17:41:54 UTC
Will do. I keep you posted.

Btw I'm with Xfce.
Comment 4 nouvo09 2023-08-18 10:29:05 UTC
Created attachment 189022 [details]
launching Calc 7.5.5
Comment 5 nouvo09 2023-08-18 10:30:24 UTC
Created attachment 189023 [details]
launching Calc 7.6.0.3
Comment 6 nouvo09 2023-08-18 10:34:29 UTC
So as shown on the to pictures I re-installed the 7.5.5 version of Calc on the same machine, the same session, the same user.
Obviously both of them cannot be launched at the same time but successsively.

Here is the proof that the DM settings or session settings ou OS have no influence in the colour.

I think there sould be a default colour in Libo itself, that noone seems to be know about.
Comment 7 QA Administrators 2023-08-19 03:19:58 UTC Comment hidden (obsolete)
Comment 8 Stéphane Guillou (stragu) 2023-08-31 23:11:38 UTC
I confirm with the gen VCL plugin:

Version: 7.6.1.1 (X86_64) / LibreOffice Community
Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

The mix of blue and maroon looks quite odd.

The change is due to the fix for bug 145080:

commit 258686a58f909ab04c7281c05f15882eb400748e
author	Heiko Tietze Wed May 17 16:48:30 2023 +0200
committer	Heiko Tietze Tue May 23 09:44:21 2023 +0200
Resolves tdf#145080 - Use accent color for focused cell
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151887

Heiko, wasn't that supposed to only affect macOS?
Comment 9 Heiko Tietze 2023-09-01 08:43:15 UTC
Effort was done for bug 145080 and bug 142121. The selection does not use a hard-coded color anymore but what is defined as accent color on the system. For Windows see https://support.microsoft.com/en-us/windows/change-colors-in-windows-d26ef4d6-819a-581c-1581-493cfcc005fe
Comment 10 Stéphane Guillou (stragu) 2023-09-01 09:03:35 UTC
Created attachment 189299 [details]
7.5 (top) vs 7.6 (bottom)

Acknowledged, but:
- the commit in question was directed a fixing a macOS issue
- the maroon colour does not match a system colour in my case (Ubuntu + GNOME), not sure where it comes from
- the result is a mix of maroon _and_ dark blue (drag corner, active cell and column header borders), whereas it was at least consistent before (only dark blue), see screenshot.

I understand and agree with using a non-modifiable accent colour coming from the system (which correctly makes the current request in summary a NAB or WF), but don't you agree that the UI got worse with that commit for x11?
Comment 11 Heiko Tietze 2023-09-01 09:25:25 UTC
KDE does per System Settings > Appearance > Color, and it seems to be the same for Ubuntu looking at https://www.debugpoint.com/ubuntu-accent-colour/

I've never seen these blue border lines. Is it a gtk-only thing?
Comment 12 Stéphane Guillou (stragu) 2023-09-01 11:24:51 UTC
(In reply to Heiko Tietze from comment #11)
> KDE does per System Settings > Appearance > Color, and it seems to be the
> same for Ubuntu looking at https://www.debugpoint.com/ubuntu-accent-colour/
> 
> I've never seen these blue border lines. Is it a gtk-only thing?

Maroon colour is:

RGB: 127 0 0
HEX: #7f0000

Blue colour is:

RGB: 0 0 127
HEX: #00007f

Which I think match our COL_RED and COL_BLUE respectively. I see your commit added:

   maAccentColor               = COL_RED;

Could that be related?
To be clear: screenshot is what I see with the gen VCL plugin, so I don't think the fact that I use Ubuntu/GNOME matters here. Right?
Comment 13 Heiko Tietze 2023-09-05 07:24:03 UTC
Created attachment 189359 [details]
Screencast accent colors on Ubuntu

Ubuntu 22.04.3
Comment 14 Stéphane Guillou (stragu) 2023-09-05 07:47:14 UTC
(In reply to Heiko Tietze from comment #13)
> Created attachment 189359 [details]
> Screencast accent colors on Ubuntu
> 
> Ubuntu 22.04.3

Have you checked with VCL=gen ?

See also Olivier's 7.6 release notes screenshot, same thing: https://wiki.documentfoundation.org/File:SortByColor.png
Comment 15 Heiko Tietze 2023-09-05 08:21:48 UTC
Created attachment 189361 [details]
VCL=gen on Ubuntu

The generic VCL uses blue as accent color with Ubuntu from the ISO (but maroon on my KDE desktop; and I still don't see mixed colors).
Comment 16 nouvo09 2023-09-09 09:54:12 UTC
On Fedora Xfce there is no way to set the appearance.
So the default colour should be defined somewhere, or is it random ? I doubt.

So where could it be?

I never found how Oliver reaches this menu.
Comment 17 Heiko Tietze 2023-09-11 05:02:24 UTC
(In reply to nouvo09 from comment #16)
> On Fedora Xfce there is no way to set the appearance.

Happy to provide help for every desktop environment, but searching the web is faster https://fostips.com/accent-color-fedora-37-gnome-43/.

Point is that we went from one hard-coded value to a color which is defined by the OS/DE. In the long run I'd be happy to have means to overwrite the use of system colors, and use a pink background on dark system colors, for example. But for now this is not possible.
Comment 18 Stéphane Guillou (stragu) 2023-09-14 10:19:55 UTC
Let's set to "won't fix" instead given that the request is to change the colour.

I've opened bug 157235 to follow-up without requesting the ability to customise.
Comment 19 nouvo09 2023-09-15 10:00:41 UTC
(In reply to Heiko Tietze from comment #17)
> (In reply to nouvo09 from comment #16)
> > On Fedora Xfce there is no way to set the appearance.
> 
> Happy to provide help for every desktop environment, but searching the web
> is faster https://fostips.com/accent-color-fedora-37-gnome-43/.

Are you aware that Xdce and Gnome are not the same thing?
search the web you'll see

> Point is that we went from one hard-coded value

Seems that we still are there at least on Xfce.