Bug 156900 - Delete row with track changes ON and show OFF doesn't hide the deleted row
Summary: Delete row with track changes ON and show OFF doesn't hide the deleted row
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes-Table
  Show dependency tree / graph
 
Reported: 2023-08-24 20:08 UTC by Telesto
Modified: 2023-09-28 07:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-08-24 20:08:10 UTC 
Description:
Delete row with track changes ON doesn't hide the deleted row

Steps to Reproduce:
1. Open attachment 188994 [details] (bug 156784)
2. Edit -> track changes -> Show (disabled) (like default)
3. Press delete row (for say the first row)

Actual Results:
Nothing happens

Expected Results:
The row with 'A' in cell A1 disappears


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c9916d9be9c060d43fc063b76d70629162650fea
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Aaron 2023-08-25 00:01:23 UTC 
Thanks for reporting. I cannot reproduce in

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-AU (fr_FR); UI: en-US
Calc: threaded
Comment 2 Stéphane Guillou (stragu) 2023-09-08 22:30:09 UTC 
Thanks Telesto!

Repro in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: beaea2e992912b4747d790070b26371f557b1f57
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and:

Version: 7.6.1.1 (X86_64) / LibreOffice Community
Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No repro in:

Version: 7.5.6.2 (X86_64) / LibreOffice Community
Build ID: f654817fb68d6d4600d7d2f6b647e47729f55f15
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-> regression.
Comment 3 Kira Tubo 2023-09-18 01:38:17 UTC 
Bibisected repository win64-7.6. Added László Németh to cc.

Regression occurring at: https://git.libreoffice.org/core/+/aff269c18b9029fec992135a406dc5031927c401


commit aff269c18b9029fec992135a406dc5031927c401	[log]
author	László Németh <nemeth@numbertext.org>	Mon May 15 19:11:11 2023 +0200
committer	László Németh <nemeth@numbertext.org>	Wed May 17 19:45:01 2023 +0200
tree d5280591723728d4570275c7093d9090ab7bc397
parent 247738a9afeeb2f0644fa0307b7023fe115fae83 [diff]

 f5161c82b52ed9b741186343facea1a1795755dd is the first bad commit
commit f5161c82b52ed9b741186343facea1a1795755dd
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Wed May 17 12:03:41 2023 -0700

    source aff269c18b9029fec992135a406dc5031927c401
Comment 4 Commit Notification 2023-09-28 07:37:45 UTC 
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5d490133efe7a2509515ac6d85ed3db0a7988b3c

tdf#156900 sw tracked table column: fix row deletion

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.