Bug 157014 - Make Comment style independent from Default
Summary: Make Comment style independent from Default
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2023-08-30 13:58 UTC by Nadie Nada Nunca
Modified: 2023-09-04 14:32 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nadie Nada Nunca 2023-08-30 13:58:09 UTC
Description:
The style for comments is inherited from the default text style, so if your default style is doublespaced, comments will be doublespaced too. They shouldn't.

Steps to Reproduce:
1. Create a new document. Write some text.
2. Insert a comment somewhere.
3. Edit the Default Paragraph Style. In "Indents & Spacing", set the line spacing to Double. In "Before text", set the value to 3. In "First line", set the value to 4.

Actual Results:
The comment text inherits the ndents and line spacing of the text paragraphs. 

Expected Results:
The comment should follow its own format, independently from the default paragraph style.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 16d43b7c5396d6382926d514dc9ce10b3ce94cba
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-AR (es_AR); UI: en-US
Calc: CL threaded
Comment 1 m_a_riosv 2023-08-30 21:44:39 UTC
IMHO, the point is that the default style should not be modified, instead a new style should be used for that.
The modification of the default style should be restricted to those options to be applied as a basis for the whole document, such as the font for example.
Comment 2 Nadie Nada Nunca 2023-08-30 22:45:18 UTC
You may well be right, but not all users are as organized as we are (the document I'm working on is good evidence of that), plus EVEN IF the user is very organized and knows what they are doing when modifying the default style, they have no good reason to think they are ALSO modifying the aspect of comments. 

Document text is one thing and comments are another thing entirely. One shouldn't affect another. It's common sense.
Comment 3 m_a_riosv 2023-08-31 00:34:06 UTC
Even if inheriting from default, you can modify the new style 'Comments'.
Comment 4 Nadie Nada Nunca 2023-08-31 10:36:31 UTC
You can. But why would a typical user think to do it? It's counterintuitive. Having this style depend on the document text style makes no sense.
Comment 5 Heiko Tietze 2023-09-01 09:12:31 UTC
In fact we mix document styles and rather UI-related layout. But some users may even want to print comments so it's not really pure UI.

I agree that the Default Paragraph Style should remain the mother of all styles, and we have to educate users to not touch it unless a global change like Sans to Serif is intended. So what we have to do in order to make comments look like it was is to pre-define all (at least most) attributes.

The comment style seems to be in an experimental state. For example, I cannot change the font.
Comment 6 Maxim Monastirsky 2023-09-01 14:06:30 UTC
I think Word does the same: It has a "Comment Text" PS that inherits from "Normal", so if you set e.g. font color or para indent in "Normal", it affects comments too. And most of the confusion here might be resolved once we stop using that "master" style as the default for new documents - see Bug 47295 (esp. note the "Reason 1" part of that report, which provides a similar reasoning). On the other hand I do agree with Heiko that we might want to predefine more attributes in the comment style, and para indent might be a good candidate for that.
Comment 7 Maxim Monastirsky 2023-09-01 14:07:24 UTC Comment hidden (off-topic)
Comment 8 Heiko Tietze 2023-09-04 13:48:55 UTC Comment hidden (off-topic)
Comment 9 Heiko Tietze 2023-09-04 13:57:22 UTC Comment hidden (off-topic)
Comment 10 Heiko Tietze 2023-09-04 14:32:44 UTC
My take regarding hard-coded attributes for "Comment" PS:

Indent before/after: 0
First line: 0
Spacing above/below: 0
Line spacing: single

Font size: 10
Font weight: regular
Font color: Automatic