Bug 157163 - NotebookBar tabs' background color does not extend to the right, "looks" broken with a wide window
Summary: NotebookBar tabs' background color does not extend to the right, "looks" brok...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All Linux (All)
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Notebookbar-Theming Notebookbar-Tabbed gtk3-themeing
  Show dependency treegraph
 
Reported: 2023-09-09 01:22 UTC by Jeff Fortin Tam
Modified: 2024-03-22 15:52 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (79.23 KB, image/png)
2023-09-09 01:24 UTC, Jeff Fortin Tam
Details
screenshot of effect of ca482cf39f25941040596e50d0e1ab7fa25dc1dd on border (99.11 KB, image/png)
2023-09-14 16:14 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2023-09-09 01:22:03 UTC
Description:
This is cosmetic, but fairly annoying, particularly in the light theme variant of the GTK3 version (a bit less noticeable in the dark version): the tab widgets have a dark gray background, but this background does not extend to the right like normal GTK applications (or even other non-native apps like Firefox).

Please see the attached screenshot.

Steps to Reproduce:
1. Launch LibreOffice on a high-resolution, very wide-screen monitor, in light mode.

Actual Results:
Tabs widgets background is not extended.

Expected Results:
Tabs widgets background should fill the empty space.


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 Jeff Fortin Tam 2023-09-09 01:24:14 UTC
Created attachment 189449 [details]
Screenshot

Pictured: LibreOffice writer (above) vs Firefox 117 (bottom-left) and the standard GTK4-demo application (bottom-right). Matching the GTK look would be ideal.
Comment 2 V Stuart Foote 2023-09-09 02:52:24 UTC
Are you using a Personalization theme?

Some similarity when the Personalization 'White' preinstalled theme while using the Light os/DE mode instead of the default look without theme. 

Otherwise can not confirm an issue for Windows builds with defaults and Personalization not in use.

=-testing-=

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d88779fc86385dde1215fd28b78a69eacc6b4f97
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 3 Jeff Fortin Tam 2023-09-09 13:20:46 UTC
No, I have no tweaks nor personalization going on. This is the default experience you get with the GTK version on Linux, whether from distro packages (such as from Fedora 38) or from the LibreOffice flatpak packages on Flathub (currently version 7.6). Many other users I've asked in public also experience this.
Comment 4 Stéphane Guillou (stragu) 2023-09-09 21:28:55 UTC
Thanks for the report, Jeff.
Which version of GNOME are you using?
Please also share the full info from Help > About LibreOffice.
Comment 5 Jeff Fortin Tam 2023-09-09 21:52:07 UTC
Bonjour Stéphane,

This is running on GNOME 44 (eventually GNOME 45)

LibreOffice Community version: 7.6.0.3 (X86_64)
Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: fr-CA (en_CA.UTF-8); UI: en-US
Flatpak
Calc: threaded

Note that this has affected every recent version of LibreOffice GTK3 I've seen in recent years, at least since the GTK3 port and the introduction of the Notebookbar, if I recall correctly.
Comment 6 Stéphane Guillou (stragu) 2023-09-14 16:14:30 UTC
Created attachment 189571 [details]
screenshot of effect of ca482cf39f25941040596e50d0e1ab7fa25dc1dd on border

(I've got an older GNOME version (3.36.8), probably why I can't reproduce.)

For me, the tab titles' background matches the rest of the space to their right. Since 7.5, there is a clearer delineation between the two, with a border drawn. Whereas in 7.4 and before, the whole length would look like one homogeneous block.
The change is from Caolán's ca482cf39f25941040596e50d0e1ab7fa25dc1dd, but looks like the issue you see is unrelated to that, seeing that you reproduced it with 7.4?
Comment 7 Jeff Fortin Tam 2023-09-15 05:23:28 UTC
From your screenshot I see that you are running Ubuntu 20.04's patched up desktop environment, which is, strictly speaking, not really GNOME; as they have their own unofficial customizations, theming (which apparently does not use any background color for GTK notebook tab widgets), it does not represent GNOME's official UX and styling. And yeah, 3.36 is 3½ years old at this point, that's seven GNOME release cycles behind ;)

The "border" you see is the delimitations of where the tabs' background color would normally be rendered, so you are seeing the same thing as me, just that your theme doesn't render it properly... Workaround to reproduce: install the "GNOME Tweaks" tool and switch your GTK theme to "Adwaita", GNOME's official look.
Comment 8 Buovjaga 2023-09-28 10:57:20 UTC
Reproduced with 7.5.6 in Debian testing.