Bug 157208 - "Find and Replace" dialog's error notifications should be more noticeable, not an unformatted label in the middle
Summary: "Find and Replace" dialog's error notifications should be more noticeable, no...
Status: RESOLVED DUPLICATE of bug 156227
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Find&Replace-Dialog
  Show dependency treegraph
 
Reported: 2023-09-12 15:05 UTC by Jeff Fortin Tam
Modified: 2023-09-14 05:56 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (105.73 KB, image/png)
2023-09-12 15:10 UTC, Jeff Fortin Tam
Details
7.6 Search and Replace Red Background (45.69 KB, image/png)
2023-09-13 17:30 UTC, larrybradley
Details
Screenshot illustrating what an OS notification to show error messages would look like on GNOME (108.16 KB, image/png)
2023-09-13 19:13 UTC, Jeff Fortin Tam
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2023-09-12 15:05:07 UTC
Description:
As shown in the attached screenshot, the "Find and Replace" dialog's error notifications are only shown as an unformatted label in the middle. This is not really a good place for them, and they are very much not noticeable.

Steps to Reproduce:
1. Ctrl+H
2. Search for an impossible term, or search twice for a term that is at the end of the document

Actual Results:
See annotated screenshot.

Expected Results:
Either show an infobar (like those infobars on startup when launching a new version of LibreOffice the first time, or when opening a document read-only) at the top of the dialog to contain the error notifications, or use the operating system's transient notifications system (ex: freedesktop notifications, etc.)


Reproducible: Always


User Profile Reset: No

Additional Info:
🚲
Comment 1 Jeff Fortin Tam 2023-09-12 15:10:45 UTC
Created attachment 189524 [details]
Screenshot

This shows the problematic error notification label widgets that blend with their surroundings.
Comment 2 Heiko Tietze 2023-09-13 07:46:30 UTC
Depending on OS/DE "erroneous input" becomes highlighted, which is reported in bug 156227 for F&R (as well as the quickfind bar) and decided to resolve by normal status on the control but more salient feedback on the label. So let's make this ticket a duplicate, although it starts with another reason.

*** This bug has been marked as a duplicate of bug 156227 ***
Comment 3 larrybradley 2023-09-13 17:30:17 UTC
Created attachment 189554 [details]
7.6 Search and Replace Red Background

Someone requested a screenshot. Here is mine.
Comment 4 larrybradley 2023-09-13 17:34:45 UTC
I would venture to say (with no offense intended) that the Screenshot from Jeff Fortin Tam was not from version 7.6. His screenshot looks like it came from version 7.5.3.3, which, as far as I'm concerned, is the way things should look in Search and Replace, but in 7.6 they don't render like in Jeff's screenshot.
Comment 5 Jeff Fortin Tam 2023-09-13 19:06:16 UTC
Can definitely confirm that I am/was running 7.6.x, albeit from flathub, so it's the GTK3 variant:

Version: 7.6.0.3 (X86_64) / LibreOffice Community
Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: fr-CA (en_CA.UTF-8); UI: en-US
Flatpak
Calc: threaded

The reason why it looks "highlighted in red" in your screenshot (but not in mine) is because your search query text is "selected"; mine isn't (and doesn't automatically get selected when I launch a search with the "Enter" key).

My issue is with the label widget, not the field.
I have no problem with the field's coloring.

Regardless of the field's coloring issue or not, my recommendation is to use an operating system notification (if not an InfoBar widget) instead of the label widget. Also, there would need to be a tooltip set on the error icon on the field (currently there is nothing set).

I would like to suggest we unmark this here as a duplicate and reopen it,
as I believe that:
- It is an independently fixable thing;
- The scope and proposed solutions are clearer here, and probably more actionable.
Comment 6 Jeff Fortin Tam 2023-09-13 19:13:12 UTC
Created attachment 189555 [details]
Screenshot illustrating what an OS notification to show error messages would look like on GNOME

As shown in this simulation screenshot,
running this command simulates approximately what I mean by "OS notifications":

    notify-send --transient --urgency="critical" "No search results found"
Comment 7 larrybradley 2023-09-13 22:31:32 UTC
Jeff, my bad. I can see now that the solid red background is intermittent, and sometimes the only thing that is red is the outline of the Search box. At any rate, I'm just going to learn to live with it. LO is so far superior to Word in all other regards that it's not worth quibbling over a cosmetic annoyance. Sorry for wasting everyone's time. I'll try to do better.
Comment 8 Heiko Tietze 2023-09-14 05:56:53 UTC
(In reply to Jeff Fortin Tam from comment #5)
> I would like to suggest we unmark this here as a duplicate and reopen it...
Both topics belong together and we use to keep the older.

The global system notification, while looking great, is way too prominent and not similarly appealing/available on all platforms.