Bug 157253 - Repaint: padding covers end of last word when changing alignment in table cell (steps in comment 7)
Summary: Repaint: padding covers end of last word when changing alignment in table cel...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: ImpressDraw-Tables
  Show dependency treegraph
 
Reported: 2023-09-15 08:17 UTC by Eyal Rozenberg
Modified: 2024-01-10 10:25 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Presentation exhibiting the problem (462.60 KB, application/vnd.oasis.opendocument.presentation)
2023-09-15 08:17 UTC, Eyal Rozenberg
Details
Screenshot of bug manifesting, note the word "social" on slide 2 (288.83 KB, image/png)
2023-09-15 08:18 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-09-15 08:17:29 UTC
Created attachment 189600 [details]
Presentation exhibiting the problem

When changing the alignment from Left to Justified in a(n LTR) table cell with thick padding, I am noticing that the edge of the last word gets swallowed/covered by the padding. Plus, when I start from Justified and switch to Left alignment, sometimes the edge of the last word stays painted in its rightward position, while the entire last word is painted further to the left.
Comment 1 Eyal Rozenberg 2023-09-15 08:18:41 UTC
Created attachment 189601 [details]
Screenshot of bug manifesting, note the word "social" on slide 2
Comment 2 m_a_riosv 2023-09-16 09:26:39 UTC
Works for me with

Version: 7.6.1.2 (X86_64) / LibreOffice Community
Build ID: f5defcebd022c5bc36bbb79be232cb6926d8f674
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
and
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b3fdd999f87312447d03915585812b3a5cd48141
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
or CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
or CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo
Comment 3 Eyal Rozenberg 2023-09-16 09:32:21 UTC
Maybe this is VCL-specific.
Comment 4 Stéphane Guillou (stragu) 2023-09-29 12:12:27 UTC
Could not reproduce with your example file, selecting the whole table and switching to justified text and then left-aligned.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2902ab24ecc5ffbf4907ea83b2028508b9de6364
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: es-MX (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Which VCL plugin are you using? I tested gtk3 and kf5 (cairo+xcb).
Please also test with a more recent master build. Maybe we need different steps.
Comment 5 Eyal Rozenberg 2023-09-30 07:16:44 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)

I'm using:

Version: 7.6.1.2 (X86_64) / LibreOffice Community
Build ID: 60(Build:2)
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.1~rc2-0ubuntu0.22.04.1~lo2

and the display is small, 1280x800.

I should mention that, on trying to reproduce, I don't manage to immediately reproduce. I have to play with it a little: Select the whole table, switch alignments back and forth, close the sidebar, switch alignments, go into the table and the leftmost cell, switch alignments, leave the table, switch alignments - something like that. And one of these triggers the bug for me.
Comment 6 QA Administrators 2023-10-01 03:17:50 UTC Comment hidden (obsolete)
Comment 7 Buovjaga 2023-10-24 11:36:17 UTC
1. Go to slide 2 in attachment 189600 [details]
2. Select the whole table
3. Change alignment to Justified
4. Focus into social
5. Change alignment to Left
6. Change alignment to Justified

Bibisected with linux-64-6.0 to f06b48a5dddab20fd1bbf9b5f3e8543593f5e590
editviewoverlay: Allow EditView to run in Overlay

I could not reproduce on Windows, but the resolution in my virtual machine is smaller (1280x800) than in my host

Arch Linux 64-bit, X11
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 11b12589c2b944f3f32d23de2794c4afddfb23b7
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 24 October 2023
Comment 8 Stéphane Guillou (stragu) 2023-11-23 09:45:14 UTC
Reproduced on macOS Ventura with a 1920×1080 display:

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 2; OS: Mac OS X 13.2.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US

Switching windows or slides repaints and shows the full word.
Comment 9 Armin Le Grand (allotropia) 2024-01-09 20:15:33 UTC
 f06b48a5dddab20fd1bbf9b5f3e8543593f5e590 is from Aug 2017 - are you sure...?
Comment 10 Stéphane Guillou (stragu) 2024-01-10 10:25:44 UTC
(In reply to Armin Le Grand from comment #9)
>  f06b48a5dddab20fd1bbf9b5f3e8543593f5e590 is from Aug 2017 - are you sure...?
I don't have the 6.0 bibisect repo currently, but I can confirm that the bug is present in:

Version: 6.0.0.0.alpha1
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group

But not in:

Version: 5.4.7.2
Build ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group

So seems to agree with Buovjaga's bisect.

I used the comment 7 steps, making sure LO is maximised on my 1920×1080 display at 100% scaling. (There's a window size threshold under which the bug does not reproduce.)