Bug 157404 - Tabbed UI: Unselected Page Size options not readable in Win11 dark mode
Summary: Tabbed UI: Unselected Page Size options not readable in Win11 dark mode
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Notebookbar-Tabbed Windows-Dark-Mode
  Show dependency tree / graph
 
Reported: 2023-09-23 22:17 UTC by Kira Tubo
Modified: 2023-10-11 23:47 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Page Size options in Tabbed UI (30.28 KB, image/png)
2023-09-23 22:18 UTC, Kira Tubo 		Details
Layout tabbed menu - Page Columns dropdown menu (18.87 KB, image/png)
2023-09-25 23:56 UTC, Kira Tubo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kira Tubo 2023-09-23 22:17:35 UTC 
Description:
If the user is running Dark Mode in Windows, they cannot read the unselected Page Size options in the tabbed UI. 

Steps to Reproduce:
1. Change Win11 to dark mode (computer Settings > Personalization > Colors > Choose your mode)
2. Open Writer
3. Change UI to Tabbed mode (View > User Interface > Tabbed)
4. Go to Layout tab and click Page Size
5. Note unselected options

Actual Results:
Page Size unselected options are not readable in dark mode. Background is white, and I suspect the text is white as well. Note that the options under Orientation, Page Column, etc. are readable.

Expected Results:
Page Size unselected options are readable in dark mode. Background should be black with white text.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 36163d269bd8f77a86605e4c5ff5adce17b4c66c
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 1 Kira Tubo 2023-09-23 22:18:16 UTC 
Created attachment 189782 [details]
Page Size options in Tabbed UI
Comment 2 Kira Tubo 2023-09-23 22:26:22 UTC 
Bibisected win64-7.5. Added Caolan McNamara to cc. 

https://git.libreoffice.org/core/+/db4c4676b70bb5f9a1c169735e8fbe92b097a57b

commit db4c4676b70bb5f9a1c169735e8fbe92b097a57b	[log]
author	Caolán McNamara <caolanm@redhat.com>	Tue Aug 16 19:30:10 2022 +0100
committer	Caolán McNamara <caolanm@redhat.com>	Wed Aug 17 12:40:02 2022 +0200
tree 81698c3bc910b2c4bd6d49dff5c76ba595feb2c3
parent ee3ebda2be3965584d12b52c007fb047d624b64c [diff]
Comment 3 Kira Tubo 2023-09-23 23:58:05 UTC 
Removing Caolan from the cc first until we get this bug verified by others.
Comment 4 Stéphane Guillou (stragu) 2023-09-25 23:34:52 UTC 
Seeing your screenshot, wondering if this is the same issue as in bug 152534.
Comment 5 Kira Tubo 2023-09-25 23:56:27 UTC 
Created attachment 189816 [details]
Layout tabbed menu - Page Columns dropdown menu

(In reply to Stéphane Guillou (stragu) from comment #4)
> Seeing your screenshot, wondering if this is the same issue as in bug 152534.

I'm not entirely sure. The issue in bug 152534 seems to be global, whereas this one seems to affect only the Page Size dropdown menu. As an example, Page Margins, Orientation, and Page Columns are unaffected. I added the attachment "Layout tabbed menu - Page Columns dropdown menu" as a sample.
Comment 6 Stéphane Guillou (stragu) 2023-09-27 17:03:18 UTC 
Thanks for the screenshots.

I think it's fair to ask Caolán what he thinks about it, given his recent work on dark mode. (But this is not his regression as his commit was about making dark mode not experimental anymore. The issue likely predates it.)
Comment 7 Justin L 2023-10-11 23:47:23 UTC 
The Page Size option is not a GTK widget, but a home-grown thing. So it acts differently to pretty much everything else. (A few other things like paragraph styles, fonts are also home-grown.)