Bug 157522 - Add "Select All" comments to make "Format all comments.." obsolete
Summary: Add "Select All" comments to make "Format all comments.." obsolete
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Comments
  Show dependency treegraph
 
Reported: 2023-09-29 21:33 UTC by Eyal Rozenberg
Modified: 2024-04-22 09:41 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-09-29 21:33:03 UTC
The bottom-of-comment drop-down menu has had, for a long time, the item "Format all comments..." which allowed setting the Font, Font Effects, Position and Highlighting. But now there's a Comment paragraph style (see bug 103064) - whose  embedded character style covers all of those.

So, I believe we should either:

1. Remove "Format all comments..." altogether, or
2. Having "Format all comments..." open the Paragraph Style dialog for the Comment PS.
Comment 1 Stéphane Guillou (stragu) 2023-09-30 00:20:36 UTC
(In reply to Eyal Rozenberg from comment #0)
> 1. Remove "Format all comments..." altogether, or

What if we kept it?

It's possible to assign any paragraph style to comment paragraphs, so one might still want to apply some direct formatting to all comments at once without having to change many styles currently used (say, assigning a font size to all comments at once because of space restrictions).
Having styles doesn't mean we need to get rid of direct formatting.

A bit like we still allow people to do Ctrl + A -> Bold on their whole document.

> 2. Having "Format all comments..." open the Paragraph Style dialog for the
> Comment PS.

Wouldn't work, because they won't necessarily have the Comment style, and they won't necessarily all have the same style.

To me -> won't fix.
Comment 2 Eyal Rozenberg 2023-09-30 06:45:05 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)

> It's possible to assign any paragraph style to comment paragraphs, so one
> might still want to apply some direct formatting to all comments at once
> without having to change many styles currently used (say, assigning a font
> size to all comments at once because of space restrictions).

That goes against the whole idea of having styles. The way you format "all things of type X" is by having them all use a named style, and changing features of that style.

Otherwise - why not "format all headings" or "format all endnotes" etc.

> Having styles doesn't mean we need to get rid of direct formatting.

Direct formatting is something you do locally, not globally.


> A bit like we still allow people to do Ctrl + A -> Bold on their whole
> document.

And people can still do that for comments if (when?) they can select multiple comments. But that's not something we encourage.


> > 2. Having "Format all comments..." open the Paragraph Style dialog for the
> > Comment PS.
> 
> Wouldn't work, because they won't necessarily have the Comment style, and
> they won't necessarily all have the same style.

True. Then - the first option. Drop this item.
Comment 3 RGB 2023-10-01 18:41:12 UTC
Another option: turn "Format all comments" into "Edit default paragraph style for comments" and use it to open the Comment paragraph style settings. This way the option will make it clear that not only the default options will be changed, but also highlights the fact that you can use non default styles too.
Comment 4 Eyal Rozenberg 2023-10-01 21:41:20 UTC
(In reply to RGB from comment #3)
> Another option: turn "Format all comments" into "Edit default paragraph
> style for comments" and use it to open the Comment paragraph style settings.

I don't think that's a useful menu item to have. It would serve to confuse more than help, if comments are currently using a different style. Remember it's kind-of a context menu for a comment.

> This way the option will make it clear that not only the default options
> will be changed, but also highlights the fact that you can use non default
> styles too.

It would be less confusing, but still confusing, and not useful enough IMO.
Comment 5 Heiko Tietze 2023-10-19 13:27:45 UTC
We discussed the topic in the design meeting and agreed to remove the command if we can offer a "Select All" method (that allows to change attributes for all).