Bug 157597 - Icon size dropdown shows wrong label when switching to Automatic
Summary: Icon size dropdown shows wrong label when switching to Automatic
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Options-Dialog-View
  Show dependency treegraph
 
Reported: 2023-10-04 13:52 UTC by Stéphane Guillou (stragu)
Modified: 2023-10-04 18:01 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-10-04 13:52:39 UTC
In Tools > Options > LibreOffice > View > Icon size, switching back to "Automatic" has the expected impact on the UI but uses the last label in the dropdown instead.

Steps:
1. Tools > Options > LibreOffice > View > Icon size, switch Toolbar to "Large", click "Apply"
2. Switch back to "Automatic", click "Apply"

Result: dropdown still displays "Large" even though the icons switched back to 

Affect both gtk3 and gen VCL plugins.

Repro in recent trunk build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f95c3994f0b6a82a3bc2ddfb68822b74479ae185
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

And in 7.1.0.3.

In 7.0.6.2, the label was correct but the UI would not change and would require closing and reopening the dialog before being able to change it, so this is not really a regression.

Caolán, this is a follow-up to this commit, which I found bibisecting with the libreoffice-64-7.1 repo:

commit 78c6e88e163f50eccc1cebdb2defe9ec4af248ce
author	Caolán McNamara 	Thu Oct 29 16:56:54 2020 +0000
committer	Caolán McNamara 	Thu Oct 29 21:22:25 2020 +0100
have just the one handler for ok/apply options
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105020

Any chance you could have a look at this minor annoyance?
Same kind of issue as in bug 137930.