Bug 157628 - No line breaks in the text in text frame
Summary: No line breaks in the text in text frame
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Content_Control
  Show dependency treegraph
 
Reported: 2023-10-06 07:27 UTC by BugReporter1
Modified: 2024-01-23 15:14 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Document contains two sentences, which should have line break between them (10.49 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-10-06 07:32 UTC, BugReporter1
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BugReporter1 2023-10-06 07:27:54 UTC
Description:
When opening document having two sentences, they are one after another without space and without line break. When opening with MS Word, the sentences are in separate rows. In LibreOffice version 7.3.0.1, this was working in a same way as in MS word, but in all later versions of LibreOffice starting from version 7.3.0.2 the sentences are shown without space and line break between them.
Maybe something has went wrong in formatting.
As attached example document, which shows this problem.

Steps to Reproduce:
1. Open the attached document LibreOfficeBugReport.docx with LibreOffice Writer

Actual Results:
There is no line break between two sentences in the document

Expected Results:
There is line break between two sentences in the document in a same way as when document is opened with MS Word or Libre Office version 7.3.0.1 or earlier. 


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 16; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 1 BugReporter1 2023-10-06 07:32:10 UTC
Created attachment 190056 [details]
Document contains two sentences, which should have line break between them
Comment 2 Kira Tubo 2023-10-11 01:55:00 UTC
Bibisected win64-7.3. Added Vasily Melenchuk to cc. 

Regression started at: 
https://git.libreoffice.org/core/+/a4432eb0946c0bc775b3d30b634bef5d66544f8d

-------------

commit a4432eb0946c0bc775b3d30b634bef5d66544f8d	[log]
author	Vasily Melenchuk <vasily.melenchuk@cib.de>	Wed Nov 24 14:50:12 2021 +0300
committer	Thorsten Behrens <thorsten.behrens@allotropia.de>	Tue Dec 21 23:23:51 2021 +0100
tree 67b339d47ba727f55b989322091f20804d9c6c09
parent c3d3eb7bdcb07824af7d205112f36201634aee59 [diff]

-------------

commit cf472b9ae9ea6e8bdc21a6f2b1768c3e4f6a6988
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Dec 21 15:18:48 2021 -0800

    source a4432eb0946c0bc775b3d30b634bef5d66544f8d

--------------

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dd7fc07f83416a3d8a444947b7d28f7347520d6a
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 3 Vasily Melenchuk (CIB) 2023-10-16 12:38:17 UTC
I did able to reproduce it with LibreOffice 7.5, but it is no longer reproducible with master.

Not sure 100%, but looks like this was fixed in:

commit 5082d50d24c3fec4487c724a15eb0d54a82ecd0d
Author: Jaume Pujantell <jaume.pujantell@collabora.com>
Date:   Wed Sep 13 08:58:21 2023 +0200

    writerfilter: use content controls for text in block SDTs

    Text inside block SDTs was shown as Text Fields wich ignored properties such as
    alias and formatting. Now those texts are imported as content controls like in
    the case of run SDTs.

    Added the ability for content controls to remember and export the "multiline"
    property of block SDT text.

    Some existing tests have been changed due to some different export results.

    Change-Id: Ice1eb4ca6dd53c99d5abb239371f8ac896c3b6e4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156867
    Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
    Tested-by: Jenkins
Comment 4 Buovjaga 2023-10-20 05:37:04 UTC
(In reply to Vasily Melenchuk (CIB) from comment #3)
> I did able to reproduce it with LibreOffice 7.5, but it is no longer
> reproducible with master.
> 
> Not sure 100%, but looks like this was fixed in:
> 
> commit 5082d50d24c3fec4487c724a15eb0d54a82ecd0d
> Author: Jaume Pujantell <jaume.pujantell@collabora.com>
> Date:   Wed Sep 13 08:58:21 2023 +0200

Yes, I checked with linux-64-24.2 bibisect repo. Let's set to fixed as there is no existing report associated with the fix.
Comment 5 Commit Notification 2024-01-23 15:14:11 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8718e362d8bb6fe3ac285ef355fc29d5756e1e92

tdf#157628: sw_layoutwriter: Add unittest

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.