Bug 157716 - Rename "Language settings" to "Languages and Locales"
Summary: Rename "Language settings" to "Languages and Locales"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low enhancement
Assignee: Stéphane Guillou (stragu)
URL:
Whiteboard: target:24.2.0 inReleaseNotes:24.2 tar...
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Options-Dialog-Language Script-Layout-Locale-Language-Mixup
  Show dependency treegraph
 
Reported: 2023-10-12 06:59 UTC by Stéphane Guillou (stragu)
Modified: 2024-04-19 08:41 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-10-12 06:59:19 UTC
I propose renaming "Tools > Options > Language Settings" to "Language and Locale", because of two reasons:

A. Other parts of the Options dialog don't have "Settings" in their name, as it's already implied by being in the "Options" dialog
B. The Language part does not relate only to language. It also contains settings for formats linked to locale. Renaming it might help users figure out that's where a default format for currency, dates and decimal numbers can be set.
Comment 1 Mike Kaganski 2023-10-12 07:56:07 UTC
+1
Comment 2 Stéphane Guillou (stragu) 2023-10-12 08:06:47 UTC
Thanks Mike.

Setting some keywords based on the see also bug 138748, hope that's OK, Hossein?

Pointer:
https://opengrok.libreoffice.org/xref/core/cui/inc/treeopt.hrc?r=e20d2de7#53

But some comments / UI hints that refer to the dialog might need updating too:
https://opengrok.libreoffice.org/search?project=core&full=%22language+settings%22&defs=&refs=&path=&hist=&type=&xrd=&nn=1&si=full&si=full&n=25
Comment 3 Hossein 2023-10-13 08:29:42 UTC
Good effort, but I see an issue:

The current layout is like this:

Language Settings
 +- Languages
 +- Writing Aids
 +- Searching in Japanese
 +- Asian Layout
 +- Complex Text Layout
 +- LanguageTool Server

After the change, the top level text would be "Language and Locale", but then the locale related settings will be inside "Languages" section.

Why not do it like this (using plural form):

Language Settings
  +- Languages and Locales
  +- ...

What do you think, Stéphane?
Comment 4 Heiko Tietze 2023-10-16 08:33:00 UTC
+1 

(In reply to Hossein from comment #3)
> Language Settings
>   +- Languages and Locales
>   +- ...
Sounds okay to me too.

> What do you think, Stéphane?
?
Comment 5 Stéphane Guillou (stragu) 2023-10-16 13:15:35 UTC
Thanks Heiko and Hossein.

(In reply to Hossein from comment #3)
> After the change, the top level text would be "Language and Locale", but
> then the locale related settings will be inside "Languages" section.

Good point, my original proposal is not enough.

> Why not do it like this (using plural form):
> 
> Language Settings
>   +- Languages and Locales
>   +- ...
> 
> What do you think, Stéphane?

As Locale is not a subset of Language, I would prefer the following:

Languages and Locales
  +- General
  +- ...

Other parts of the Options dialog (LibreOffice, Load/Save, Writer) already have such a "General" section.

Would that suit everyone?
Comment 6 Commit Notification 2023-11-18 15:01:41 UTC
t-aswath committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0264999bb3746a9c68938edd1a6fc05a8e40b406

tdf#157716 - Rename "Language settings" to "Languages and Locales"

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Buovjaga 2023-11-18 15:42:05 UTC
After the rename, Help files referencing this option path also need to be updated.
Comment 8 Heiko Tietze 2023-11-20 08:14:35 UTC
Thanks for the patch, aswath t
Comment 9 Buovjaga 2023-11-20 09:26:34 UTC
NEW while we wait for Help adjustments
Comment 10 Commit Notification 2023-11-24 14:46:21 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/b1830be3caa3fae67973f8370aaf1a5e820e3caa

tdf#157716 Rename "Language settings" to "Languages and Locales"
Comment 11 Stéphane Guillou (stragu) 2023-11-27 14:13:17 UTC
A side effect is that now, extension-provided options like "English Sentence Checking" have their own "Language Settings" section.
Therefore, some more follow-up needed in the dictionaries repo: https://opengrok.libreoffice.org/search?project=dictionaries&full=%22Language+Settings%22&defs=&refs=&path=&hist=&type=&xrd=&nn=1&si=full&si=full

Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 86c682273d907c77404637c89e584047de1c1099
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 12 Adolfo Jayme Barrientos 2024-03-13 21:22:12 UTC
Reopen per comment 11. In the meantime, I did adjustments on Weblate for my language so that the sections don't appear duplicated.
Comment 13 Heiko Tietze 2024-03-14 08:07:42 UTC
(In reply to Adolfo Jayme Barrientos from comment #12)
> Reopen per comment 11.
But it's NOB and has to be fixed on the extension/3rd-party side. Why reopen this ticket?
Comment 14 Mike Kaganski 2024-03-14 09:19:39 UTC
(In reply to Heiko Tietze from comment #13)

"English Sentence Checking" item is provided by the bundled Lightproof. It is definitely our bug.
Comment 15 Stéphane Guillou (stragu) 2024-04-16 00:40:09 UTC
(In reply to Mike Kaganski from comment #14)
> "English Sentence Checking" item is provided by the bundled Lightproof. It
> is definitely our bug.
Should be good now for en, hu_HU, pt_BR and ru_RU dialogs with https://gerrit.libreoffice.org/c/dictionaries/+/166137
Comment 16 Commit Notification 2024-04-18 05:55:25 UTC
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/dictionaries/commit/8c5b63124f5cedf97ed4799560fdd1202f039511

tdf#157716 rename 'Language Settings' to 'Languages and Locales'
Comment 17 Stéphane Guillou (stragu) 2024-04-18 15:54:59 UTC
Should be good for bundled dictionaries as well now.