Bug 157729 - Group comment threads in navigator
Summary: Group comment threads in navigator
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.1.2 release
Hardware: All All
: medium enhancement
Assignee: Jim Raykowski
URL:
Whiteboard: target:24.2.0 inReleaseNotes:24.2
Keywords:
Depends on:
Blocks: Navigator Writer-Comments
  Show dependency treegraph
 
Reported: 2023-10-12 18:02 UTC by lomacar
Modified: 2024-06-26 09:04 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Navigator group comment threads demo (902.67 KB, video/x-matroska)
2023-11-28 08:07 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lomacar 2023-10-12 18:02:27 UTC
Description:
It would be helpful to have comment threads grouped in the navigator pane, rather than just having a flat list.

Also, why is there a large gap from the └    to the items in the navigator?

Steps to Reproduce:
This is a enhancement suggestion, there are no steps to reproduce.

Actual Results:
This is a enhancement suggestion.

Expected Results:
This is a enhancement suggestion.


Reproducible: Always


User Profile Reset: No

Additional Info:
This is a enhancement suggestion.
Comment 1 Heiko Tietze 2023-10-16 13:09:24 UTC
Please elaborate on the use case ("I want to achieve Foo by doing Bar and get stuck at Baz") and perhaps illustrate what you have in mind. I suspect the issue has been requested, so you could save time by browsing through bug 106179 resp. bug 107431.

So far I get that you think "Many margin comments/notes are complicated to use", bug 38295.
Comment 2 lomacar 2023-10-16 21:55:47 UTC
I don't know what more to say. I am not talking about comments in the margins. I am talking about the Navigator (F5) in Writer, which lists Headings, Tables, Comments, etc. All the comments are listed in a flat list even though they may be comment threads (ie. One person makes a comment in the document and then people reply to that comment). Sometimes there can be several comments forming a conversation at one place in the document. It is unintuitive and a poor use of space to have all those reply comments displayed in the navigator at the same level as the original comments that start the conversations (threads). It makes it difficult to actually navigate the comments in the Navigator on a document with dozens or hundreds of comments.

I guess in the Navigator you can see which comments are original and which ones are replies because the replies by default start with "Reply to ..." But in the Navigator view it would be better if that "Reply to..." text wasn't shown and the replies were just nested under the starting comment.

It would actually be better, IMHO, if the comments in the Navigator started with the name of the commenter followed by a colon, but that is a separate enhancement request, I guess.
Comment 3 lomacar 2023-10-16 22:04:45 UTC
(In reply to Heiko Tietze from comment #1)
> Please elaborate on the use case ("I want to achieve Foo by doing Bar and
> get stuck at Baz") and perhaps illustrate what you have in mind. I suspect
> the issue has been requested, so you could save time by browsing through bug
> 106179 resp. bug 107431.
> 
> So far I get that you think "Many margin comments/notes are complicated to
> use", bug 38295.

The bugs you linked to are not helpful. The first own is a list of Calc comment bugs. The second one has nothing in it except some spam comments. The third one is talking about the display of comments in the comment margin, but I am talking about the list of comments in the Navigator.

I did try searching for related bugs before I posted but I couldn't find anything. The search was giving a lot of unrelated results though.
Comment 4 QA Administrators 2023-10-17 03:14:05 UTC Comment hidden (obsolete)
Comment 5 Heiko Tietze 2023-10-17 13:16:01 UTC
(In reply to lomacar from comment #2)
> I am talking about the Navigator (F5)... All the comments are listed in
> a flat list even though they may be comment threads
That makes sense.

Something for you, Jim?
Comment 6 Jim Raykowski 2023-11-28 08:07:48 UTC
Created attachment 191071 [details]
Navigator group comment threads demo

Would what is shown in the video work?

The patch that does this is here:
https://gerrit.libreoffice.org/c/core/+/160011

Looking at the code it appears a reply to a comment reply uses the original comment as it's parent, not the reply comment. This probably isn't a bad thing.
Comment 7 Heiko Tietze 2023-11-28 08:25:36 UTC
(In reply to Jim Raykowski from comment #6)
> Looking at the code it appears a reply to a comment reply uses the original
> comment as it's parent, not the reply comment. This probably isn't a bad
> thing.
Awesome! So we don't run into deep hierarchy issues with comment > reply > reply... making the tree unmanageable. Sounds good to me.

What do you think, lomacar?
Comment 8 Commit Notification 2023-12-05 20:52:35 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8286c9ebe47aaf24b055f51136a8cb06f1e6429c

tdf#157729 SwNavigator: enhancement to group comments by threads

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 lomacar 2023-12-14 20:20:44 UTC
(In reply to Heiko Tietze from comment #7)
> (In reply to Jim Raykowski from comment #6)
> > Looking at the code it appears a reply to a comment reply uses the original
> > comment as it's parent, not the reply comment. This probably isn't a bad
> > thing.
> Awesome! So we don't run into deep hierarchy issues with comment > reply >
> reply... making the tree unmanageable. Sounds good to me.
> 
> What do you think, lomacar?

Perfect, thank you!
Comment 10 Jim Raykowski 2023-12-14 22:31:21 UTC
OK, let's mark this one as fixed :-)
Comment 11 Stéphane Guillou (stragu) 2024-01-26 11:31:40 UTC
In release notes: https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F24.2&type=revision&diff=731006&oldid=730975

Verified in:

Version: 24.2.0.2 (X86_64) / LibreOffice Community
Build ID: b1fd3a6f0759c6f806568e15c957f97194bbec8f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you Jim!
Comment 12 Tagimu Gedjobil 2024-06-26 08:49:18 UTC Comment hidden (spam)