Bug 157773 - LibreOffice Impress 7.5 Autofit text overflow
Summary: LibreOffice Impress 7.5 Autofit text overflow
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Autofit
  Show dependency treegraph
 
Reported: 2023-10-14 13:03 UTC by Horst Schirmeier
Modified: 2024-04-29 12:21 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
reproducer (17.98 KB, application/vnd.oasis.opendocument.presentation)
2023-10-14 13:04 UTC, Horst Schirmeier
Details
LO Impress 7.4.7.2 screenshot (104.17 KB, image/png)
2023-10-14 13:06 UTC, Horst Schirmeier
Details
LO Impress 7.5.6.2 screenshot (111.60 KB, image/png)
2023-10-14 13:06 UTC, Horst Schirmeier
Details
LO Impress 7.5.7.1 screenshot (111.62 KB, image/png)
2023-10-14 13:07 UTC, Horst Schirmeier
Details
LO Impress 7.6.2.1 screenshot (107.28 KB, image/png)
2023-10-14 13:07 UTC, Horst Schirmeier
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Horst Schirmeier 2023-10-14 13:03:27 UTC
Description:
In LibreOffice Impress 7.5 (reproducible e.g. in 7.5.6.2 and 7.5.7.1), "Autofit text" doesn't work correctly anymore: When the box is overfull, the font size is reduced (as expected), but the text still flows outside the box.  It works correctly in LO 7.4.7.2, and seems to be fixed in 7.6.2.1.

Steps to reproduce:
 -  Open attached autofit-textbox.odp in LO Impress 7.5.

Expected behavior:
 -  Text stays within the master slide's content text box.

Actual behavior:
 -  Text overflows textbox vertically.

Steps to Reproduce:
Open attached autofit-textbox.odp in LO Impress 7.5.

Actual Results:
Text overflows textbox vertically.

Expected Results:
Text stays within the master slide's content text box.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.6.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 20; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Debian package version: 4:7.5.6-1
Calc: threaded
Comment 1 Horst Schirmeier 2023-10-14 13:04:12 UTC
Created attachment 190208 [details]
reproducer
Comment 2 Horst Schirmeier 2023-10-14 13:06:37 UTC
Created attachment 190209 [details]
LO Impress 7.4.7.2 screenshot
Comment 3 Horst Schirmeier 2023-10-14 13:06:54 UTC
Created attachment 190210 [details]
LO Impress 7.5.6.2 screenshot
Comment 4 Horst Schirmeier 2023-10-14 13:07:10 UTC
Created attachment 190211 [details]
LO Impress 7.5.7.1 screenshot
Comment 5 Horst Schirmeier 2023-10-14 13:07:30 UTC
Created attachment 190212 [details]
LO Impress 7.6.2.1 screenshot
Comment 6 Horst Schirmeier 2023-10-14 13:16:38 UTC
Note that the text is also generally rendered differently in the two screenshots with correct autofitting (7.4.7.2 / attachment 190209 [details] and 7.6.2.1 / attachment 190212 [details]), which might be considered a separate regression.  Maybe related to bug 156990.
Comment 7 Horst Schirmeier 2023-10-14 13:38:12 UTC
This bug is also reproducible in the 7.5.8.1 prerelease.
Comment 8 Stéphane Guillou (stragu) 2023-10-16 10:49:17 UTC
Thanks for the report.

Although there were some text display/formatting issues right before this commit (maybe related to 4c349be1d74c669e5804c3c43f3f0a3960c88bc5?), I bibisected with the linux-64-7.5 repo to first bad commit 2074fe900c9dc74594f9bc4fb66fb3c483009739 which points to core commit:

commit 7f73a779e33dd91fad0111629c6b3420c2c9aea0
author	Tomaž Vajngerl 	Wed Nov 02 20:15:31 2022 +0100
committer	Tomaž Vajngerl 	Thu Nov 03 09:53:54 2022 +0100
optimize text fitting algorithm to correctly calculate the fit
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142186

Quikee, can you please have a look?
Bug 156990 might be related (but has unclear repro steps).
Comment 9 Tomaz Vajngerl 2024-04-29 08:40:56 UTC
Is there still something to fix here?
Comment 10 Stéphane Guillou (stragu) 2024-04-29 10:05:10 UTC
Resolved in 7.6 by:

commit 628275acb1b9652e65b8c5c013549dce5ad6f5bf
author	Tomaž Vajngerl 	Thu Mar 23 11:24:30 2023 +0900
committer	Tomaž Vajngerl	Sun Mar 26 15:07:39 2023 +0000
tdf#90407 Change the auto-fit alg. to match better with OOXML
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149207

7.5 is EOL so we're good.

Thanks Quikee, you can close as "resolved - fixed"!