Bug 157788 - Saving the "Show navigation panel" setting for a device
Summary: Saving the "Show navigation panel" setting for a device
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Slide-Show
  Show dependency treegraph
 
Reported: 2023-10-15 17:45 UTC by Vladislav Tarakanov
Modified: 2023-11-06 08:44 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Tarakanov 2023-10-15 17:45:51 UTC
Description:
Currently, the value of the "Show navigation panel" parameter for presentations is not saved. The section in which this setting is now located, apparently, is saved in files. It might make sense to move this setting to Tools -> Options -> LibreOffice Impress -> General, because it relates to the device rather than the slideshow.

Steps to Reproduce:
1. Open Impress, create a presentation
2. Enable "Show navigation panel" in Slide show -> Slide show settings...
3. Restart impress, create a new presentation
4. Start presentation

Actual Results:
Navigation panel is not visible

Expected Results:
Navigation panel is visible


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 m_a_riosv 2023-10-16 01:22:30 UTC
It should be saved per file, I think.

But it is not saved, neither per file nor Impress app.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 2 Vladislav Tarakanov 2023-10-16 06:25:08 UTC
(In reply to m.a.riosv from comment #1)
> It should be saved per file, I think.
> 
> But it is not saved, neither per file nor Impress app.

It looks like when we added this functionality, we did not implement saving settings.

Before we can start fixing this problem, we need to decide where to save these settings. The feature was originally conceived for devices on which it is impossible or difficult to use a mouse (for example, on interactive whiteboards). For these devices, it seems it would be better to save the setting per Impress app rather than per file.
Comment 3 Stéphane Guillou (stragu) 2023-10-16 10:08:15 UTC
Let's check with UX/Design where such a setting should live.
My gut-feeling is agreeing with you, that if it's expected to be user profile-dependent, the option should be in Tools > Options > LibreOffice Impress > General > Presentation.
Comment 4 Heiko Tietze 2023-10-16 12:52:13 UTC
The options in Slide Show Settings should all apply to the workstation, eg. whether it is capable playing animations or whether you need the buttons to click through the presentation. Plus, saving some options with the document and others at the workstation is barely comprehensible for users. So make it consistent.
Comment 5 Amin Irgaliev 2023-10-17 07:38:11 UTC
(In reply to Heiko Tietze from comment #4)
> The options in Slide Show Settings should all apply to the workstation, eg.
> whether it is capable playing animations or whether you need the buttons to
> click through the presentation. Plus, saving some options with the document
> and others at the workstation is barely comprehensible for users. So make it
> consistent.

We added a patch to Gerrit with the transfer of the navigation panel in presentations, can you tell, who we can invite to the review?
Comment 6 Heiko Tietze 2023-10-17 07:55:55 UTC
(In reply to Amin Irgaliev from comment #5)
> We added a patch to Gerrit with the transfer of the navigation panel in
> presentations, can you tell, who we can invite to the review?

Thanks for your patch. Great work!
Comment 7 Commit Notification 2023-10-17 07:56:22 UTC
Irgaliev Amin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0e14912af0c449396f10c2ae4be3c7f2a3a98bc2

tdf#157788 Saving the "Show navigation panel" setting for a device

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Amin Irgaliev 2023-10-17 09:55:55 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to Amin Irgaliev from comment #5)
> > We added a patch to Gerrit with the transfer of the navigation panel in
> > presentations, can you tell, who we can invite to the review?
> 
> Thanks for your patch. Great work!

Can we backport this patch to version 7.6.3?
Comment 9 Heiko Tietze 2023-10-17 10:19:19 UTC
(In reply to Amin Irgaliev from comment #8)
> Can we backport this patch to version 7.6.3?

We usually do not backport enhancements. Keep the thrill of anticipation :-)
Comment 10 Xisco Faulí 2023-10-17 10:23:05 UTC
(In reply to Amin Irgaliev from comment #8)
> (In reply to Heiko Tietze from comment #6)
> > (In reply to Amin Irgaliev from comment #5)
> > > We added a patch to Gerrit with the transfer of the navigation panel in
> > > presentations, can you tell, who we can invite to the review?
> > 
> > Thanks for your patch. Great work!
> 
> Can we backport this patch to version 7.6.3?

The patch contains UI strings, so definitely not a good idea to backport it. Why do you want to backport it ?
Comment 11 Amin Irgaliev 2023-10-17 11:27:00 UTC
(In reply to Xisco Faulí from comment #10)
> (In reply to Amin Irgaliev from comment #8)
> > (In reply to Heiko Tietze from comment #6)
> > > (In reply to Amin Irgaliev from comment #5)
> > > > We added a patch to Gerrit with the transfer of the navigation panel in
> > > > presentations, can you tell, who we can invite to the review?
> > > 
> > > Thanks for your patch. Great work!
> > 
> > Can we backport this patch to version 7.6.3?
> 
> The patch contains UI strings, so definitely not a good idea to backport it.
> Why do you want to backport it ?

This option has not been saved previously. People who use, for example, interactive boards often use this option. Therefore, we thought that the faster the version with this patch comes out, the better.
Comment 12 Amin Irgaliev 2023-10-17 11:34:22 UTC
(In reply to Amin Irgaliev from comment #11)
> (In reply to Xisco Faulí from comment #10)
> > (In reply to Amin Irgaliev from comment #8)
> > > (In reply to Heiko Tietze from comment #6)
> > > > (In reply to Amin Irgaliev from comment #5)
> > > > > We added a patch to Gerrit with the transfer of the navigation panel in
> > > > > presentations, can you tell, who we can invite to the review?
> > > > 
> > > > Thanks for your patch. Great work!
> > > 
> > > Can we backport this patch to version 7.6.3?
> > 
> > The patch contains UI strings, so definitely not a good idea to backport it.
> > Why do you want to backport it ?
> 
> This option has not been saved previously. People who use, for example,
> interactive boards often use this option. Therefore, we thought that the
> faster the version with this patch comes out, the better.

But if it can cause difficulties, then all right.
Comment 13 Adolfo Jayme Barrientos 2023-10-17 22:05:01 UTC
There is always the possibility of asking for a UI Freeze exception on the l10n list, so that the translated strings are exceptionally unblocked for this enhancement.
Comment 14 Commit Notification 2023-11-06 08:44:16 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e0334e1a77ec080b38952ea64b394c8652af851c

tdf#157788 Move "Show navigation panel" back to Presentation settings

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.