Bug 157869 - UI strings "columns number" and "columns spacing" are not proper English
Summary: UI strings "columns number" and "columns spacing" are not proper English
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: BogdanB
URL:
Whiteboard: target:25.2.0
Keywords: difficultyBeginner, easyHack, skillDesign
Depends on:
Blocks:
 
Reported: 2023-10-20 20:50 UTC by Tuomas Hietala
Modified: 2024-12-02 07:57 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2023-10-20 20:50:05 UTC
Description:
The UI strings "columns number" and "columns spacing" are not proper English and their meanings are a bit unclear. The meanings might be "Number of columns" for the first one and "Spacing of columns" / "Column spacing" for the second, but I haven't checked.

Steps to Reproduce:
1. See https://translations.documentfoundation.org/translate/libo_ui-master/svxmessages/en/?checksum=92c916f1dcce67a6 and https://translations.documentfoundation.org/translate/libo_ui-master/svxmessages/en/?checksum=bb377b5ca1b7931c


Actual Results:
The strings are not proper English.

Expected Results:
The strings are proper English and factually correct.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Heiko Tietze 2023-10-23 06:27:44 UTC
Introduced by Mike in https://gerrit.libreoffice.org/c/core/+/116038 (no BZ reference). It could be "Number of columns" or "Column's Number". The first one is used in the accompanying dialog.

Code pointer: include/svx/strings.hrc
Comment 2 Mike Kaganski 2023-10-23 06:33:52 UTC
(In reply to Heiko Tietze from comment #1)
> (no BZ reference)

Mea culpa! :-)
FTR: all my commits labelled "editengine-columns" are related to the feature implemented as a fix for bug 118458 and similar.
The meta for further enhancements to that feature is bug 142729.
Comment 3 BogdanB 2024-11-24 18:30:04 UTC
if you agree on:
- Number of columns
- Column spacing

The change is in gerrit https://gerrit.libreoffice.org/c/core/+/177220
Comment 4 Tuomas Hietala 2024-11-30 19:52:20 UTC
(In reply to BogdanB from comment #3)
> if you agree on:
> - Number of columns
> - Column spacing
> 
> The change is in gerrit https://gerrit.libreoffice.org/c/core/+/177220

These are certainly better English. Has someone checked if the meanings are correct, though?
Comment 5 Mike Kaganski 2024-11-30 20:10:42 UTC
(In reply to Tuomas Hietala from comment #4)
> (In reply to BogdanB from comment #3)
> > if you agree on:
> > - Number of columns
> > - Column spacing
> > 
> > The change is in gerrit https://gerrit.libreoffice.org/c/core/+/177220
> 
> These are certainly better English. Has someone checked if the meanings are
> correct, though?

The current "columns number" is "how many columns to create". The "columns spacing" is "how much space (or what distance) must be between the columns". I *believe* that the meaning of the new strings is correct - but being the non-native English speaker, and guilty of the original bad wording, I have no say in this :-D
Comment 6 Tuomas Hietala 2024-11-30 20:31:23 UTC
(In reply to Mike Kaganski from comment #5)
> (In reply to Tuomas Hietala from comment #4)
> > (In reply to BogdanB from comment #3)
> > > if you agree on:
> > > - Number of columns
> > > - Column spacing
> > > 
> > > The change is in gerrit https://gerrit.libreoffice.org/c/core/+/177220
> > 
> > These are certainly better English. Has someone checked if the meanings are
> > correct, though?
> 
> The current "columns number" is "how many columns to create". The "columns
> spacing" is "how much space (or what distance) must be between the columns".
> I *believe* that the meaning of the new strings is correct - but being the
> non-native English speaker, and guilty of the original bad wording, I have
> no say in this :-D

Thanks. While I'm non-native too, I think the proposed strings correspond to what you're describing, so +1 from me.
Comment 7 Commit Notification 2024-12-02 07:57:07 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f52aafac08731e3f60b49c912f4169394d787d66

tdf#157869 Improve description for columns in textbox (Impress)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.