Bug 158003 - Unify lockdown behavior of Options dialog page Writing Aids
Summary: Unify lockdown behavior of Options dialog page Writing Aids
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: UI-Lockdown
  Show dependency treegraph
 
Reported: 2023-10-31 10:20 UTC by Gabor Kelemen (allotropia)
Modified: 2023-11-10 10:19 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Lock down extension for the Writing Aids page (1.76 KB, application/vnd.openofficeorg.extension)
2023-10-31 10:20 UTC, Gabor Kelemen (allotropia)
Details
The Writing Aids page after installing the extension (94.80 KB, image/png)
2023-10-31 10:23 UTC, Gabor Kelemen (allotropia)
Details
The Language Modules editing dialog after installing the extension (42.78 KB, image/png)
2023-10-31 10:27 UTC, Gabor Kelemen (allotropia)
Details
Updated lockdown extension for Languages - Writing Aids page (1.86 KB, application/vnd.openofficeorg.extension)
2023-11-08 10:12 UTC, Gabor Kelemen (allotropia)
Details
Updated lockdown extension for Languages - Writing Aids page (1.86 KB, application/vnd.openofficeorg.extension)
2023-11-08 15:30 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-10-31 10:20:48 UTC
Created attachment 190540 [details]
Lock down extension for the Writing Aids page

When the settings of the Options dialog page Writing Aids are locked down, several of the UI elements do not reflect this by becoming disabled and displaying a lock icon on their left.

1. Install the attached extension in the Tools - Extensions dialog
2. Restart LibreOffice
3. Go to Tools - Options - Language Settings - Writing Aids
-> the UI elements have no lock icon on their left, they are not disabled, the Edit buttons on the right side open their value editing dialogs. Changes made there are silently ignored.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3649dc202bedf72e37c77993a1f7027bfdfc6d9e
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2023-10-31 10:23:42 UTC
Created attachment 190541 [details]
The Writing Aids page after installing the extension
Comment 2 Gabor Kelemen (allotropia) 2023-10-31 10:27:26 UTC
Created attachment 190542 [details]
The Language Modules editing dialog after installing the extension

So first on the other screenshot the enabled language modules are for the Hungarian locale, which is perhaps from the system default - I'm not sure where that came, UI langauage and locale were set to en-US in the Languages tab and the extension locks down the en-US specific settings.
These options in the dialog should be disabled, but selecting other language at the top and opening this dialog with the Edit button should be still allowed.
Comment 3 Buovjaga 2023-10-31 17:09:51 UTC
Confirmed

Arch Linux 64-bit, X11
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c8da023efe26efcb166c3525ca73fe62f26e154c
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 31 October 2023
Comment 4 Gabor Kelemen (allotropia) 2023-11-08 10:12:01 UTC
Created attachment 190717 [details]
Updated lockdown extension for Languages - Writing Aids page

commented on what the keys cover on the UI
Comment 5 Gabor Kelemen (allotropia) 2023-11-08 15:30:19 UTC
Created attachment 190728 [details]
Updated lockdown extension for Languages - Writing Aids page

added missing key IsSpellAuto, removed one unneeded
Comment 6 Commit Notification 2023-11-10 10:16:19 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/985b404f208559b4a91f31eb31dafa9d0384fdaf

tdf#158003 - UI: Part 22 - Unify lockdown behavior of Options dialog

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.