Bug 158043 - pptx import, placeholder shape missing, wrong inheritance from layout page
Summary: pptx import, placeholder shape missing, wrong inheritance from layout page
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, regression
Depends on:
Blocks: PPTX-MasterSlide
  Show dependency treegraph
Reported: 2023-11-02 14:37 UTC by Sven-Jacobi
Modified: 2023-12-19 16:16 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

placeholder field missing, wrong text displayed on slide (18.39 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2023-11-02 14:37 UTC, Sven-Jacobi
screenshot-office365-one-shape-on-slide-with-correct-placeholder-text (61.38 KB, image/jpeg)
2023-11-03 08:45 UTC, Sven-Jacobi
screenshot-windows-7-5-6-no-shape-on-slide-wrong-placeholder-text (92.97 KB, image/jpeg)
2023-11-03 08:46 UTC, Sven-Jacobi

Note You need to log in before you can comment on or make changes to this bug.
Description Sven-Jacobi 2023-11-02 14:37:09 UTC
Created attachment 190616 [details]
placeholder field missing, wrong text displayed on slide

This bug is a regression, everything works fine in LO 7.1.6. The first version I found this problem was in LO 7.4.5.

If you load the attached document then there should be one shape on the first slide. If loading in LO 7.4.5 and later versions the shape on the first slide is missing.
Comment 1 m_a_riosv 2023-11-02 21:41:32 UTC
Opening with
Microsoft® PowerPoint® para Microsoft 365 MSO (versión 2310 compilación 16.0.16924.20054) de 64 bits 

there is nothing either.
Comment 2 Sven-Jacobi 2023-11-03 08:45:47 UTC
Created attachment 190631 [details]
Comment 3 Sven-Jacobi 2023-11-03 08:46:25 UTC
Created attachment 190632 [details]
Comment 4 Sven-Jacobi 2023-11-03 08:47:28 UTC
This bug seems to be the result of following commit:

pptx: import shape text from master page

If shape has custom text defined in master page
but no text itself - don't prefer placeholder text
but text from master page.

Change-Id: Id4f7aeca0e74ecd8565905cd656a182c1195fa30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154980
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155335
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Comment 5 Sven-Jacobi 2023-11-03 08:51:29 UTC
My comments on this:

Also if the placeholder shape does not have its own text it's not a good idea to remove this shape for following reasons:

- the user may want to remove the placeholder
- the user may want to move / resize the placeholder
- or the user want to have different text within the placeholder ...

If this shape is missing it is not easy to archive this.
Comment 6 raal 2023-11-09 20:32:20 UTC
confirm with Version: (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

154980: pptx: import shape text from master page | https://gerrit.libreoffice.org/c/core/+/154980

Adding Cc to: Szymon Kłos
Comment 7 Aron Budea 2023-12-19 16:16:39 UTC
That's strange, because the mentioned commit is only in 24.2 and 7.6, and definitely not in 7.5 or 7.4 as the attachment name and the specified version number suggests.

For me this started between and