Bug 158096 - Selection of lighter Preinstalled Themes under Personalization (Options) leaves menu ribbon icons white and unreadable
Summary: Selection of lighter Preinstalled Themes under Personalization (Options) leav...
Status: RESOLVED DUPLICATE of bug 121877
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.7.1 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-07 03:04 UTC by TH
Modified: 2023-12-15 13:12 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TH 2023-11-07 03:04:10 UTC
If one selects the lighter-colored Preinstalled Themes under Personalization (Options), the icons in the menu ribbon (at the top of the application, such as Writer for example), become unreadable (i.e., they remain white, etc., and that does NOT work with the lighter themes).  This makes use of lighter themes UNTENABLE, and thus BROKEN.
Comment 1 Mike Kaganski 2023-11-07 05:43:49 UTC
I think it is not a bug - you likely use dark desktop mode, which works with respective dark-mode icons; and unless you change that, use of light icon theme with dark mode is not something expected to work (the darkmode icons were created for that).
Comment 2 Buovjaga 2023-11-08 16:02:46 UTC
NEEDINFO while we wait for TH to respond.
Comment 3 TH 2023-11-08 22:43:43 UTC
No, but it IS a bug.  Mike, your suggestion that use of a light icon theme with dark mode (OS dark mode) "is not something expected to work) is INCORRECT.  Here's the problem: if one changes the OS's dark mode to light mode, for example, then ALL applications are affected, NOT just LibreOffice.  In version 7.4.x of LibreOffice, with the OS being set to dark mode, the light themes in LibreOffice DO have properly readable menu ribbon icons, etc.  It is in later version of LibreOffice, that this is broken.  NO ONE should be required to have their OS set to non-dark-mode in order to be able to successfully use a lighter in-built theme in LibreOffice, and that should NOT be your expectation.

Regardless of the OS mode in-place, whether it is dark mode or something else, LibreOffice's lighter themes should have READABLE menu ribbon and other icons, period.  They were readable in version 7.4.x and earlier, now they are NOT when the OS is in dark mode.  That is a bug and break in LibreOffice itself, and needs to be corrected / fixed.
Comment 4 QA Administrators 2023-11-09 03:16:37 UTC Comment hidden (obsolete)
Comment 5 Stéphane Guillou (stragu) 2023-11-09 09:30:04 UTC
(In reply to TH from comment #3)
> In version 7.4.x of LibreOffice, with the OS being set to dark mode, the
> light themes in LibreOffice DO have properly readable menu ribbon icons,
> etc.  It is in later version of LibreOffice, that this is broken.
This is likely because of better dark mode support since LO 7.5 and the fix for bug 152183: now the icon theme changes automatically to a light theme if the OS is in dark mode, which is a great improvement.
If you overwrite the OS theme with a Personnalisation theme, you have to change the icon theme to a suitable one. This was actually already the case before 7.5, the other way around: if you used a dark Personnalisation theme, you would have had to change the icon theme to an icon theme suitable for a dark theme.
> NO ONE
> should be required to have their OS set to non-dark-mode in order to be able
> to successfully use a lighter in-built theme in LibreOffice, and that should
> NOT be your expectation.
...you should be able to change between dark mode and light mode just for LibreOffice, in Tools > Options > View > Appearance. No need to change it for the whole OS.
Comment 6 Stéphane Guillou (stragu) 2023-11-09 09:35:34 UTC
(and regarding the tabbed interface, how inconsistently the theme is applied to it is a blocker anyway, see bug 121877)
Comment 7 TH 2023-11-29 00:56:56 UTC
(In reply to Stéphane Guillou (stragu) from comment #5)
> (In reply to TH from comment #3)
> > In version 7.4.x of LibreOffice, with the OS being set to dark mode, the
> > light themes in LibreOffice DO have properly readable menu ribbon icons,
> > etc.  It is in later version of LibreOffice, that this is broken.
> This is likely because of better dark mode support since LO 7.5 and the fix
> for bug 152183: now the icon theme changes automatically to a light theme if
> the OS is in dark mode, which is a great improvement.
> If you overwrite the OS theme with a Personnalisation theme, you have to
> change the icon theme to a suitable one. This was actually already the case
> before 7.5, the other way around: if you used a dark Personnalisation theme,
> you would have had to change the icon theme to an icon theme suitable for a
> dark theme.
> > NO ONE
> > should be required to have their OS set to non-dark-mode in order to be able
> > to successfully use a lighter in-built theme in LibreOffice, and that should
> > NOT be your expectation.
> ...you should be able to change between dark mode and light mode just for
> LibreOffice, in Tools > Options > View > Appearance. No need to change it
> for the whole OS.

FALSE.  Switching to light mode in the latest version of LibreOffice, as I earlier pointed out very carefully, leaves the ribbon icons UNREADABLE and thus UNUSABLE.  Additionally, the dark mode support since LO 7.5 clearly thus BREAKS the light mode themes.  You seem to have FAILED even to test these things, before commenting, or my points would be self-evident to you, as being CORRECT.  You also seem to have FAILED to actually pay attention to what I stated, in full, when identifying this new bug / break in the lighter themes, etc.  Your comments are simply WRONG, from start to finish, in regard to what I am saying.
Comment 8 TH 2023-11-29 00:59:55 UTC
ADDITIONALLY, there is NO clear way to change the "icon theme" when switching to a lighter theme in LO 7.5, to make the ribbon icons legible.  In fact, I see NO way at all to do that.
Comment 9 Stéphane Guillou (stragu) 2023-11-29 08:20:17 UTC
(In reply to TH from comment #7)
> FALSE.  Switching to light mode in the latest version of LibreOffice, as I
> earlier pointed out very carefully, leaves the ribbon icons UNREADABLE and
> thus UNUSABLE.  Additionally, the dark mode support since LO 7.5 clearly
> thus BREAKS the light mode themes.  You seem to have FAILED even to test
> these things, before commenting, or my points would be self-evident to you,
> as being CORRECT.  You also seem to have FAILED to actually pay attention to
> what I stated, in full, when identifying this new bug / break in the lighter
> themes, etc.  Your comments are simply WRONG, from start to finish, in
> regard to what I am saying.
Please remain cordial when interacting here. I _have_ tested it, and I _do_ actually see what you describe. I simply explain what the causes are: one recent improvement (automatic icon switch depending on OS setting) and long-standing issues that are already known (application themes requiring the user to pick a suitable icon theme, and application themes not applying uniformly to the tabbed interface - bug 121877).

As a workaround to the current issues with Personalization Themes, I'd recommend not using one but instead making use of the improved dark mode support, by going to Options > LibreOffice > View, and picking the LO Appearance that suits you (Light or Dark), and change to an icon theme you prefer.

(In reply to TH from comment #8)
> ADDITIONALLY, there is NO clear way to change the "icon theme" when
> switching to a lighter theme in LO 7.5, to make the ribbon icons legible. 
> In fact, I see NO way at all to do that.
Options > LibreOffice > View > Icon Theme.

Finally, if you really want to make sure others understand exactly what you mean, please share exactly:
- what Windows settings you are using
- which Personalization Theme you picked
- which settings are used in Options > LibreOffice > View
- a screenshot of the issue
Comment 10 TH 2023-12-14 23:08:59 UTC
(In reply to Stéphane Guillou (stragu) from comment #9)
> (In reply to TH from comment #7)
> > FALSE.  Switching to light mode in the latest version of LibreOffice, as I
> > earlier pointed out very carefully, leaves the ribbon icons UNREADABLE and
> > thus UNUSABLE.  Additionally, the dark mode support since LO 7.5 clearly
> > thus BREAKS the light mode themes.  You seem to have FAILED even to test
> > these things, before commenting, or my points would be self-evident to you,
> > as being CORRECT.  You also seem to have FAILED to actually pay attention to
> > what I stated, in full, when identifying this new bug / break in the lighter
> > themes, etc.  Your comments are simply WRONG, from start to finish, in
> > regard to what I am saying.
> Please remain cordial when interacting here. I _have_ tested it, and I _do_
> actually see what you describe. I simply explain what the causes are: one
> recent improvement (automatic icon switch depending on OS setting) and
> long-standing issues that are already known (application themes requiring
> the user to pick a suitable icon theme, and application themes not applying
> uniformly to the tabbed interface - bug 121877).
> 
> As a workaround to the current issues with Personalization Themes, I'd
> recommend not using one but instead making use of the improved dark mode
> support, by going to Options > LibreOffice > View, and picking the LO
> Appearance that suits you (Light or Dark), and change to an icon theme you
> prefer.
> 
> (In reply to TH from comment #8)
> > ADDITIONALLY, there is NO clear way to change the "icon theme" when
> > switching to a lighter theme in LO 7.5, to make the ribbon icons legible. 
> > In fact, I see NO way at all to do that.
> Options > LibreOffice > View > Icon Theme.
> 
> Finally, if you really want to make sure others understand exactly what you
> mean, please share exactly:
> - what Windows settings you are using
> - which Personalization Theme you picked
> - which settings are used in Options > LibreOffice > View
> - a screenshot of the issue

You seem to NOT understand: there are NO suitable icon themes, as the icons are NOT sufficiently visible in the latest versions of LibreOffice, when any lighter scheme is chosen inside the application and DARK MODE is being used in Windows itself (e.g., in Windows 10).  You suggest choosing "an icon theme you prefer," but the problem is this: there are NONE, as they are ALL broken, as soon as once choose ANY light theme in LibreOffice while having Windows OS itself set to use Dark Mode.  I do NOT want to have to use Light Mode in Windows simply to be able to actually use a current version of LibreOffice Writer with a light theme.
Comment 11 TH 2023-12-14 23:31:51 UTC
(In reply to TH from comment #10)
> (In reply to Stéphane Guillou (stragu) from comment #9)
> > (In reply to TH from comment #7)
> > > FALSE.  Switching to light mode in the latest version of LibreOffice, as I
> > > earlier pointed out very carefully, leaves the ribbon icons UNREADABLE and
> > > thus UNUSABLE.  Additionally, the dark mode support since LO 7.5 clearly
> > > thus BREAKS the light mode themes.  You seem to have FAILED even to test
> > > these things, before commenting, or my points would be self-evident to you,
> > > as being CORRECT.  You also seem to have FAILED to actually pay attention to
> > > what I stated, in full, when identifying this new bug / break in the lighter
> > > themes, etc.  Your comments are simply WRONG, from start to finish, in
> > > regard to what I am saying.
> > Please remain cordial when interacting here. I _have_ tested it, and I _do_
> > actually see what you describe. I simply explain what the causes are: one
> > recent improvement (automatic icon switch depending on OS setting) and
> > long-standing issues that are already known (application themes requiring
> > the user to pick a suitable icon theme, and application themes not applying
> > uniformly to the tabbed interface - bug 121877).
> > 
> > As a workaround to the current issues with Personalization Themes, I'd
> > recommend not using one but instead making use of the improved dark mode
> > support, by going to Options > LibreOffice > View, and picking the LO
> > Appearance that suits you (Light or Dark), and change to an icon theme you
> > prefer.
> > 
> > (In reply to TH from comment #8)
> > > ADDITIONALLY, there is NO clear way to change the "icon theme" when
> > > switching to a lighter theme in LO 7.5, to make the ribbon icons legible. 
> > > In fact, I see NO way at all to do that.
> > Options > LibreOffice > View > Icon Theme.
> > 
> > Finally, if you really want to make sure others understand exactly what you
> > mean, please share exactly:
> > - what Windows settings you are using
> > - which Personalization Theme you picked
> > - which settings are used in Options > LibreOffice > View
> > - a screenshot of the issue
> 
Okay, I had replied to the above in haste.  Your suggestion to use Options -> LibreOffice -> View, etc., works.  ALSO, it appears that there as been some improvement since I commented in November on the Personalization theme options as well, where the ribbon icons are concerned.  THANK YOU!
Comment 12 QA Administrators 2023-12-15 03:14:22 UTC Comment hidden (obsolete)
Comment 13 Stéphane Guillou (stragu) 2023-12-15 13:12:25 UTC
OK, thank you for following the suggestion and reporting back.
Let's mark as duplicate of bug 121877 as the issue is somewhat related.

*** This bug has been marked as a duplicate of bug 121877 ***