Bug 158341 - FILEOPEN DOCX Endless loop on opening file
Summary: FILEOPEN DOCX Endless loop on opening file
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.3.1 rc
Hardware: All All
: high major
Assignee: Miklos Vajna
URL:
Whiteboard: target:24.2.0 target:7.6.4
Keywords: bibisected, bisected, regression
: 137859 (view as bug list)
Depends on:
Blocks: DOCX-Floatingtable
  Show dependency treegraph
 
Reported: 2023-11-23 19:24 UTC by Gabor Kelemen (allotropia)
Modified: 2024-01-04 08:40 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word 2016 (36.44 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-11-23 19:24 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-11-23 19:24:29 UTC
Created attachment 191002 [details]
Example file from Word 2016

Attached document contains a floating table and some pages of text.
When opened, this causes a layout loop.

1. Open attached file
-> Endless loop

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9602f8a9318dd4d3409856e2ae06abe96e72b51b
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Seems to have started with:

https://git.libreoffice.org/core/+/25b8fdd3b939a221ba00ca37fbf89adaf893aab7

author	Miklos Vajna <vmiklos@collabora.com>	Thu Sep 28 09:03:27 2023 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	Thu Sep 28 09:52:41 2023 +0200

sw floattable: maintain the invariant that fly height is at least MINFLY

Adding CC to: Miklos Vajna
Comment 1 Stéphane Guillou (stragu) 2023-11-23 20:29:43 UTC
Thanks Gabor.

Repro in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and:

Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

(was cherrypicked as 60e2fdf1d7e8346e5a3835369c47e582c737ce20)

No repro in:

Version: 7.5.8.2 (X86_64) / LibreOffice Community
Build ID: f718d63693263970429a68f568db6046aaa9df01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 Commit Notification 2023-11-29 08:57:51 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ce2fc5eb29b4e252993b549dee002fa8948c8386

tdf#158341 sw floattable: fix layout loop when fly is below the body frame

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2023-11-30 09:23:24 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/d9c85df89513d63263c6e852ad68ec780dbce0c2

tdf#158341 sw floattable: fix layout loop when fly is below the body frame

It will be available in 7.6.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Stéphane Guillou (stragu) 2023-12-01 12:54:03 UTC
Verified in:

Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 619500d6919c227e734b119481a4b334972e0b7b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Miklos!
Comment 5 Miklos Vajna 2023-12-05 10:53:19 UTC
*** Bug 137859 has been marked as a duplicate of this bug. ***