Bug 158396 - Frame title should show DocumentTitle when set in MediaDescriptor
Summary: Frame title should show DocumentTitle when set in MediaDescriptor
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:24.2.0 target:7.6.4
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-27 09:15 UTC by Mike Kaganski
Modified: 2023-11-30 09:24 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2023-11-27 09:15:25 UTC
When creating a new document, users can set a "DocumentTitle" ( https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1document_1_1MediaDescriptor.html#a30b085fcd9a9cf8698c57c6c74f315b2 ), which is documented as "This parameter can be used to specify a title for a document".

It is also set for a recovered document ( see StorageFilterDetect::detect at https://opengrok.libreoffice.org/xref/core/filter/source/storagefilterdetect/filterdetect.cxx?r=b1560344&mo=4839&fi=86#141 ).

When setting that, the frame title still shows "Untitled x" (possibly with "(Recovered document)").

Instead it should display the name given as DocumentTitle (if available).
Comment 1 Mike Kaganski 2023-11-27 09:20:26 UTC
https://gerrit.libreoffice.org/c/core/+/159904
Comment 2 Mike Kaganski 2023-11-27 10:54:26 UTC
For a test: open attachment 121217 [details] using "Word 2010-365 Document" filter explicitly. This sets the respective property in MediaDescriptor in https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/sfxbasemodel.cxx?r=baecfd21#2003.
Comment 3 Commit Notification 2023-11-27 11:55:16 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6ea42a11669e2b3d3a10dd5eb199f45d6050c86b

tdf#158396: show DocumentTitle when set in MediaDescriptor

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-11-30 09:24:27 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/e9b7aa5c8246e9e199011e2636d79f00efb79b9e

tdf#158396: show DocumentTitle when set in MediaDescriptor

It will be available in 7.6.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.