Bug 158398 - Android Viewer: Improve display of spreadsheet row/column headers
Summary: Android Viewer: Improve display of spreadsheet row/column headers
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Android Viewer (show other bugs)
Version:
(earliest affected)
7.6.3.2 release
Hardware: All Android
: medium enhancement
Assignee: Michael Weghorn
URL:
Whiteboard: target:24.2.0 target:7.6.4
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-27 09:46 UTC by Michael Weghorn
Modified: 2023-11-29 12:43 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Sample document (9.26 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-11-27 09:46 UTC, Michael Weghorn
Details
Screenshot of spreadsheet in Calc headers on Android (55.89 KB, image/png)
2023-11-27 09:47 UTC, Michael Weghorn
Details
Screenshot with pending Gerrit changes in place (70.55 KB, image/png)
2023-11-27 10:12 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2023-11-27 09:46:41 UTC
Created attachment 191057 [details]
Sample document

Quoting from a Google Play review of LibreOffice Viewer app:

> The answer here showed me where I can find the other tables in
> the Calc document, but something like fixing columns and rows
> doesn't work. The area on the left where the line names are is
> much too wide for me.

Indeed, the row-header labels are left-aligned and there's quite a lot of unused space. This should be further improved.
I think that aligning it more with the desktop version of LibreOffice makes sense: center the label, make the background light grey.

Steps to reproduce:

1) open attached "calc_headers.ods" in Android Viewer (or use any other .ods file)
2) look at the row/column headers
Comment 1 Michael Weghorn 2023-11-27 09:47:29 UTC
Created attachment 191058 [details]
Screenshot of spreadsheet in Calc headers on Android
Comment 2 Michael Weghorn 2023-11-27 10:12:19 UTC
Created attachment 191059 [details]
Screenshot with pending Gerrit changes in place

The attached screenshot shows what this looks like with these pending Gerrit changes in place:

https://gerrit.libreoffice.org/c/core/+/159989 (v1) + the changes that this one depends on
Comment 3 Commit Notification 2023-11-27 13:04:28 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7c7e044f3cd6adc8ce639d01dc083827cdd87266

tdf#158398 android: Center Calc header text

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-11-27 13:04:30 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d134615570bd7afb045f983cdd008c5662265504

tdf#158398 android: Draw light gray background for Calc headers

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-11-29 12:43:21 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/f4d9f597d1192a688900fda7f11f75c5804196ce

tdf#158398 android: Center Calc header text

It will be available in 7.6.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-11-29 12:43:23 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/615705acd731150e029587daafc1226d1e07a108

tdf#158398 android: Draw light gray background for Calc headers

It will be available in 7.6.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.