Bug 158416 - Infobars / banners don't use text colour anymore
Summary: Infobars / banners don't use text colour anymore
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Infobar-UX
  Show dependency treegraph
 
Reported: 2023-11-28 11:03 UTC by Stéphane Guillou (stragu)
Modified: 2023-11-28 12:22 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Old/New color (12.04 KB, image/png)
2023-11-28 11:14 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-11-28 11:03:41 UTC
Infobars got text colours adapted to background colours in 5.4 for bug 105829 but that got lost in 6.1.

Bibisected with linux-64-6.1 to first bad build commit [b94b86dc2bdb09da488c9f0c0f28fb8594e63023] which points to core commit:

commit de1b926fa294273caefb29a507e117b8487e882b
author	Caolán McNamara  Fri Jan 12 16:57:18 2018 +0000
committer	Caolán  Sat Jan 13 22:23:53 2018 +0100
Foreground colors adjusted
to comply with WCAG 2.0 level AAA requiring a contrast of 7:1
Reviewed-on: https://gerrit.libreoffice.org/47825
Comment 1 Heiko Tietze 2023-11-28 11:14:23 UTC
Created attachment 191077 [details]
Old/New color

(In reply to Stéphane Guillou (stragu) from comment #0)
> Bibisected with linux-64-6.1 to first bad build commit..
But this patch just adjusts the color a little bit. The font color seems to be black now (and changing the foreground to 1,0,0 makes only the closing X red, not the text).
Comment 2 Stéphane Guillou (stragu) 2023-11-28 11:24:39 UTC
(In reply to Heiko Tietze from comment #1)
> But this patch just adjusts the color a little bit. The font color seems to
> be black now (and changing the foreground to 1,0,0 makes only the closing X
> red, not the text).
As said in the Design chat, my understanding is that that the new solution in patchset 4 does not bring back rMessageColor inside the switch.
Comment 3 Heiko Tietze 2023-11-28 12:22:05 UTC
True, overlooked the messagecolor. Caolan, how about keeping it simple with rForegroundColor instead?