Bug 158492 - share/config/images_helpimg.zip should'nt be in the main MSI archive and in libobasis7.6-images deb archive
Summary: share/config/images_helpimg.zip should'nt be in the main MSI archive and in l...
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
7.6.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Win-Installer-Smaller Installer-Linux
  Show dependency treegraph
 
Reported: 2023-12-02 19:42 UTC by Jérôme
Modified: 2024-01-18 07:02 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme 2023-12-02 19:42:44 UTC
I extracted the content of the LibreOffice_7.6.3_Win_x86-64.msi archive (345MB) with msiextract.
This main MSI archive installs the below file :
share/config/images_helpimg.zip

The content of this zip file looks like the content of the below directory :
help/media/helpimg

If this file can be deleted, it would save roughly 1 MB into the main MSI archive.
Comment 1 Gabor Kelemen (allotropia) 2023-12-02 21:30:01 UTC
It' not unused, these are images used by the local help.

From Repository.mk:

        $(if $(ENABLE_HTMLHELP),\
                helpcontent2_html_dynamic \
                helpcontent2_html_media \
                helpcontent2_html_icon-themes \
                helpcontent2_html_static \

and in helpcontent2/Package_html_media.mk lists the images/example files. Grepping for their name shows that these are referenced from help files, for example:

gabor@voldemort:~/src/core/helpcontent2$ git grep files/scalc/conditionalformatting.ods 
Package_html_media.mk:    files/scalc/conditionalformatting.ods \
source/text/scalc/06/calcsamplefiles.xhp:        <paragraph role="paragraph" id="par_id591563765191143" localize="false"><object data="media/files/scalc/conditionalformatting.ods" id="ods_id61521525603534" type="application/vnd.oasis.opendocument.spreadsheet" /></paragraph>

gabor@voldemort:~/src/core/helpcontent2$ git grep what-if.png
Package_html_media.mk:    helpimg/what-if.png \
source/text/scalc/guide/multioperation.xhp:<image id="img_id1621753" src="media/helpimg/what-if.png"><alt id="alt_id1621753" xml-lang="en-US">what-if sheet area</alt></image></paragraph>

gabor@voldemort:~/src/core/helpcontent2$ git grep swh00179.png
Package_html_media.mk:    helpimg/swh00179.png \
source/text/shared/guide/tabs.xhp:<image id="img_id3153192" src="media/helpimg/swh00179.png" width="0.2228inch" height="0.2228inch"><alt id="alt_id3153192" xml-lang="en-US">Icon</alt>
Comment 2 Jérôme 2023-12-03 10:29:20 UTC
If it is a source file, then it shouldn't be into the main MSI archive.
Comment 3 Jérôme 2023-12-10 17:14:30 UTC
This file is also in :
libobasis7.6-images_7.6.4.1-1_amd64.deb
Comment 4 Jérôme 2024-01-17 19:20:43 UTC
I understand share/config/images_helpimg.zip is never used at runtime. The files inside this archive are duplicated outside this archive.

Since "share/config/images_helpimg.zip" is a "source" file, why is it packaged into the target help archive ?