Spin-off from bug 143340: Keep Ratio is so far set via extra checbox which seems to be part of the image attribute but isn't. To make it more obvious a design that connects the two controls might be an improvement. Patch WIP at https://gerrit.libreoffice.org/c/core/+/159835
Take caution: * Related to making Keep ratio default. There are still a or maybe even more bugs in the calculation mechanism as far I can tell. See bug 158535. * Related to Keep ratio as such: The setting is behaving as global setting for all images (all though you open the dialog for specific image). So unticking keep ratio (if default) might affect all images too. Needs testing.. * There is the thing about storing the setting. So if the checkbox Keep ratio in checked for certain image or not. Losing the setting at each session might be annoying, more a minor inconvenience
I forgot, please update the commit message so it's reflecting the new bug report
Created attachment 191443 [details] Screenshot with https://gerrit.libreoffice.org/c/core/+/160460 v3 in place for discussion there
I might have mixed up the light/dark images. But the actual question is whether we want this change or keep with the simple checkbox. I'm not so convinced anymore.
(In reply to Heiko Tietze from comment #4) > I might have mixed up the light/dark images. But the actual question is > whether we want this change or keep with the simple checkbox. I'm not so > convinced anymore. From a user perspective, I personally like the new approach - if applied consistently across all the dialogs that have something like this. Maybe a good candidate for discussion in the design meeting?
(In reply to Heiko Tietze from comment #4) > But the actual question is whether we want this change or keep with the simple > checkbox. I'm not so convinced anymore. Would you mind to explain why?
I don't recall a design with checkbox for this purpose. It is often with flat button with lock or unlock icon depending on the state. What the background is for picking a checkbox? The function it offers is surely nice to have from end-user perspective, IMHO
I like the new proposal more than the current implementation. I think it is cleaner. Especially, if the new checkbox had a tooltip like "lock ratio", or something like that. A visual differentiation from checkboxes also could be a good idea. For example, GIMP has an icon on the Image -> Scale Image -> Image size dialog, which was clear for me at first sight.
We discussed the topic in the design meeting. The effort is appreciated, and since reverting the patch is easy, we should continue.
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fe4e750d32cb88a9ce7a7539af6c6883d4194220 Resolves tdf#158531 - Connector lines for Keep Ratio setting It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 192521 [details] screenshot Verified with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5dadcd1ea9e63bcbc0a5d4c4cd95d7d8b37edef9 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded See before and after Before is: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded