Bug 158577 - Allow locking down adding new trusted authors
Summary: Allow locking down adding new trusted authors
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.5
Keywords: bibisectRequest, regression
Depends on:
Blocks: Digital-Signatures
  Show dependency treegraph
 
Reported: 2023-12-07 10:21 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2023-12-11 14:26 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example extension to lock down the key (1.48 KB, application/vnd.openofficeorg.extension)
2023-12-07 10:22 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2023-12-07 10:21:28 UTC
In macro mode "High", only macros from a trusted location or certificate can be run.
However, the user can easily add certificates to the list of trusted certs.

There should be a way to lock this down so that users can't add certificates to the list of trusted sources themselves.
Comment 1 Gabor Kelemen (allotropia) 2023-12-07 10:22:21 UTC Comment hidden (obsolete)
Comment 2 Samuel Mehrbrodt (allotropia) 2023-12-07 12:05:06 UTC
This was fixed with bug 129311, but was broken with commit https://git.libreoffice.org/core/+/6ed8c5a0f19901ab413c6610649326b2475c3a8c%5E%21

That commit added a TODO which needs to be fixed:

        case SvtSecurityOptions::EOption::MacroTrustedAuthors:
            bReadonly = m_bROTrustedAuthors;
            bReadonly = false; // TODO? officecfg::Office::Common::Security::Scripting::TrustedAuthors::isReadOnly();
Comment 3 Commit Notification 2023-12-08 08:48:31 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c0e438eaceb47932e61b9223e048e4eda3ed7636

tdf#158577 Allow locking down adding new trusted authors

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-12-11 14:26:13 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/5ab183c0f2757d8f6a4ebe6476b98c924ee06c48

tdf#158577 Allow locking down adding new trusted authors

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.